-
Notifications
You must be signed in to change notification settings - Fork 13.7k
Remove named lifetimes in some PartialOrd & PartialEq impls
#143575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, do we know what caused this change? It seems a bit unexpected for what is (I think) supposed to be a no-op change to change the diagnostic like this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No idea, sadly
Makes the docs way easier to look at, gets rid of a few
#[allow(unused_lifetimes)], and AFAICT is completely equivalent.