Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Unquerify maybe_unused_trait_imports. #143373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bors merged 1 commit into rust-lang:master from cjgillot:bare-unused-trait-imports
Jul 22, 2025

Conversation

Copy link
Contributor

@cjgillot cjgillot commented Jul 3, 2025

Based on #143247
r? @ghost for perf

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jul 3, 2025
@petrochenkov petrochenkov added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jul 4, 2025
@cjgillot cjgillot force-pushed the bare-unused-trait-imports branch from 4da4f27 to 0b30b4f Compare July 4, 2025 14:01
Copy link
Contributor Author

cjgillot commented Jul 4, 2025

@bors try @rust-timer queue

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 4, 2025
bors added a commit that referenced this pull request Jul 4, 2025 
Unquerify maybe_unused_trait_imports.
Based on #143247
r? `@ghost` for perf
Copy link
Collaborator

bors commented Jul 4, 2025

⌛ Trying commit 0b30b4f with merge 891c2a6...

Copy link
Collaborator

bors commented Jul 4, 2025

☀️ Try build successful - checks-actions
Build commit: 891c2a6 (891c2a61a2cbf1ee300377d54b986b02bc6fca55)

This comment has been minimized.

Copy link
Collaborator

Finished benchmarking commit (891c2a6): comparison URL.

Overall result: ❌ regressions - please read the text below

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @rustbot label: +perf-regression-triaged. If not, please fix the regressions and do another perf run. If its results are neutral or positive, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)		 3.0% [3.0%, 3.0%] 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 3.0% [3.0%, 3.0%] 1

Max RSS (memory usage)

Results (secondary -0.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 0.7% [0.6%, 0.8%] 2
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.1% [-2.1%, -2.1%] 1
All ❌✅ (primary) - - 0

Cycles

Results (secondary -1.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 0.5% [0.5%, 0.5%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.2% [-2.7%, -1.5%] 4
All ❌✅ (primary) - - 0

Binary size

Results (primary 1.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 1.1% [1.1%, 1.1%] 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 1.1% [1.1%, 1.1%] 1

Bootstrap: 461.146s -> 461.655s (0.11%)
Artifact size: 372.20 MiB -> 372.23 MiB (0.01%)

@rustbot rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Jul 4, 2025
@cjgillot cjgillot force-pushed the bare-unused-trait-imports branch from 0b30b4f to 258e410 Compare July 20, 2025 13:26
@rustbot rustbot added the T-clippy Relevant to the Clippy team. label Jul 20, 2025
@petrochenkov petrochenkov added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 21, 2025
@petrochenkov petrochenkov marked this pull request as ready for review July 21, 2025 14:57
Copy link
Collaborator

rustbot commented Jul 21, 2025

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

Copy link
Contributor

This is a simplification and the perf diff seems to be noise.
r=me unless you want to do something else with this (the PR was never marked as waiting on review).
@bors rollup=maybe
@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 21, 2025
Copy link
Collaborator

rustbot commented Jul 21, 2025

Reminder, once the PR becomes ready for a review, use @rustbot ready.

Copy link
Contributor Author

@bors r=petrochenkov

Copy link
Collaborator

bors commented Jul 22, 2025

📌 Commit 258e410 has been approved by petrochenkov

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 22, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 22, 2025 
..., r=petrochenkov
Unquerify maybe_unused_trait_imports.
Based on rust-lang#143247
r? `@ghost` for perf
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 22, 2025 
..., r=petrochenkov
Unquerify maybe_unused_trait_imports.
Based on rust-lang#143247
r? ``@ghost`` for perf
bors added a commit that referenced this pull request Jul 22, 2025 
Rollup of 8 pull requests
Successful merges:
 - #142454 (Add modern AVR mcus like avr128db28 and attiny3224)
 - #142924 (tidy: move rustdoc js stuff into a tidy extra check)
 - #143373 (Unquerify maybe_unused_trait_imports.)
 - #143906 (Miri: non-deterministic floating point operations in `foreign_items`)
 - #144082 (tests: cover more `exported_private_dependencies` cases)
 - #144126 (Fix empty target_config in apply_rust_config bootstrap)
 - #144164 ( opt-dist: add an option for setting path to stage0 root)
 - #144265 (Dont ICE on copy error being suppressed due to overflow)
r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit that referenced this pull request Jul 22, 2025 
Rollup of 7 pull requests
Successful merges:
 - #142454 (Add modern AVR mcus like avr128db28 and attiny3224)
 - #142924 (tidy: move rustdoc js stuff into a tidy extra check)
 - #143373 (Unquerify maybe_unused_trait_imports.)
 - #144082 (tests: cover more `exported_private_dependencies` cases)
 - #144126 (Fix empty target_config in apply_rust_config bootstrap)
 - #144164 ( opt-dist: add an option for setting path to stage0 root)
 - #144265 (Dont ICE on copy error being suppressed due to overflow)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit b934f1a into rust-lang:master Jul 22, 2025
11 checks passed
@rustbot rustbot added this to the 1.90.0 milestone Jul 22, 2025
rust-timer added a commit that referenced this pull request Jul 22, 2025 
Rollup merge of #143373 - cjgillot:bare-unused-trait-imports, r=petrochenkov
Unquerify maybe_unused_trait_imports.
Based on #143247
r? ```@ghost``` for perf
@cjgillot cjgillot deleted the bare-unused-trait-imports branch July 22, 2025 16:16
flip1995 pushed a commit to flip1995/rust that referenced this pull request Jul 25, 2025 
..., r=petrochenkov
Unquerify maybe_unused_trait_imports.
Based on rust-lang#143247
r? ```@ghost``` for perf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Labels
perf-regression Performance regression. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.90.0
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /