Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Port #[no_mangle] to new attribute parsing infrastructure #142823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bors merged 1 commit into rust-lang:master from JonathanBrouwer:no_mangle_parser
Jun 23, 2025

Conversation

Copy link
Contributor

@JonathanBrouwer JonathanBrouwer commented Jun 21, 2025

Ports no_mangle to the new attribute parsing infrastructure for #131229 (comment)

r? @jdonszelmann

Copy link
Collaborator

rustbot commented Jun 21, 2025

jdonszelmann is currently at their maximum review capacity.
They may take a while to respond.

@rustbot rustbot added A-attributes Area: Attributes (`#[...]`, `#![...]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 21, 2025
Copy link
Collaborator

rustbot commented Jun 21, 2025

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

Some changes occurred in compiler/rustc_codegen_ssa

cc @WaffleLapkin

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann

Some changes occurred in compiler/rustc_attr_data_structures

cc @jdonszelmann

Some changes occurred in compiler/rustc_codegen_ssa/src/codegen_attrs.rs

cc @jdonszelmann

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann

rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead.

cc @rust-lang/rust-analyzer

This comment has been minimized.

This comment has been minimized.

@rustbot rustbot added has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 21, 2025
@rustbot rustbot removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. has-merge-commits PR has merge commits, merge with caution. labels Jun 21, 2025
Copy link
Contributor Author

Woops I accidentally rebased on the wrong commit and git did not like that, should be good now :P

This comment has been minimized.

Copy link
Contributor

r=me after that and ci

Copy link
Contributor

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 21, 2025
Copy link
Collaborator

rustbot commented Jun 21, 2025

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@rustbot rustbot added the A-rustdoc-json Area: Rustdoc JSON backend label Jun 21, 2025
Copy link
Collaborator

rustbot commented Jun 21, 2025

rustdoc-json-types is a public (although nightly-only) API. If possible, consider changing src/librustdoc/json/conversions.rs; otherwise, make sure you bump the FORMAT_VERSION constant.

cc @CraftSpider, @aDotInTheVoid, @Enselic, @obi1kenobi

These commits modify tests/rustdoc-json.
rustdoc-json is a public (but unstable) interface.

Please ensure that if you've changed the output:

  • It's intentional.
  • The FORMAT_VERSION in src/librustdoc-json-types is bumped if necessary.

cc @aDotInTheVoid, @obi1kenobi

@rustbot rustbot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jun 21, 2025
Copy link
Collaborator

bors commented Jun 21, 2025

☔ The latest upstream changes (presumably #142826) made this pull request unmergeable. Please resolve the merge conflicts.

Copy link
Contributor Author

@rustbot ready
Rebased on latest master, reverted the change to the warning until #142836 is decided, and made rustdocs output no_mangle correctly in the json repr

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 22, 2025
Copy link
Contributor

@jdonszelmann jdonszelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bors r+ rollup

Copy link
Contributor Author

Rebased to solve merge conflicts

 

Signed-off-by: Jonathan Brouwer <jonathantbrouwer@gmail.com>
Copy link
Contributor Author

Rebased to solve merge conflicts

Copy link
Contributor

@bors r+ rollup

Copy link
Collaborator

bors commented Jun 22, 2025

📌 Commit 2084831 has been approved by jdonszelmann

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 22, 2025
jhpratt added a commit to jhpratt/rust that referenced this pull request Jun 22, 2025 
...r=jdonszelmann
Port `#[no_mangle]` to new attribute parsing infrastructure
Ports `no_mangle` to the new attribute parsing infrastructure for rust-lang#131229 (comment)
r? `@jdonszelmann`
bors added a commit that referenced this pull request Jun 23, 2025 
Rollup of 6 pull requests
Successful merges:
 - #140136 (Add an aarch64-msvc build running on ARM64 Windows)
 - #141597 (Document subdirectories of UI tests with README files)
 - #142823 (Port `#[no_mangle]` to new attribute parsing infrastructure)
 - #142828 (1.88.0 release notes)
 - #142854 (centralize `-Zmin-function-alignment` logic)
 - #142875 (Check rustdoc-json-types FORMAT_VERSION is correctly updated)
r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit that referenced this pull request Jun 23, 2025 
Rollup of 5 pull requests
Successful merges:
 - #141597 (Document subdirectories of UI tests with README files)
 - #142823 (Port `#[no_mangle]` to new attribute parsing infrastructure)
 - #142828 (1.88.0 release notes)
 - #142854 (centralize `-Zmin-function-alignment` logic)
 - #142875 (Check rustdoc-json-types FORMAT_VERSION is correctly updated)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 9b6665f into rust-lang:master Jun 23, 2025
10 checks passed
@rustbot rustbot added this to the 1.89.0 milestone Jun 23, 2025
rust-timer added a commit that referenced this pull request Jun 23, 2025 
Rollup merge of #142823 - JonathanBrouwer:no_mangle_parser, r=jdonszelmann
Port `#[no_mangle]` to new attribute parsing infrastructure
Ports `no_mangle` to the new attribute parsing infrastructure for #131229 (comment)
r? ``@jdonszelmann``
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Jun 23, 2025 
...t, r=jdonszelmann
Fix comment on NoMangle
Fix comment on NoMangle.
This was discussed in comments of rust-lang#142823 (comment) and rust-lang#142921
rust-timer added a commit that referenced this pull request Jun 24, 2025 
Rollup merge of #142922 - JonathanBrouwer:fix-rustdoc-comment, r=jdonszelmann
Fix comment on NoMangle
Fix comment on NoMangle.
This was discussed in comments of #142823 (comment) and #142921
github-actions bot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Jun 26, 2025 
Rollup of 5 pull requests
Successful merges:
 - rust-lang/rust#141597 (Document subdirectories of UI tests with README files)
 - rust-lang/rust#142823 (Port `#[no_mangle]` to new attribute parsing infrastructure)
 - rust-lang/rust#142828 (1.88.0 release notes)
 - rust-lang/rust#142854 (centralize `-Zmin-function-alignment` logic)
 - rust-lang/rust#142875 (Check rustdoc-json-types FORMAT_VERSION is correctly updated)
r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez left review comments

@fmease fmease fmease left review comments

@aDotInTheVoid aDotInTheVoid aDotInTheVoid left review comments

@jdonszelmann jdonszelmann jdonszelmann approved these changes

+1 more reviewer

@obi1kenobi obi1kenobi obi1kenobi left review comments

Reviewers whose approvals may not affect merge requirements
Labels
A-attributes Area: Attributes (`#[...]`, `#![...]`) A-rustdoc-json Area: Rustdoc JSON backend S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.
Projects
None yet
Milestone
1.89.0
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /