-
Notifications
You must be signed in to change notification settings - Fork 13.7k
[crater] Add impl From<f16> for f32
#142723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@bors2 try
[crater] Add `impl From<f16> for f32` Crater run to see what the effects of adding `impl From<f16> for f32` without changing the fallback (a.k.a. things that would be caught by the FCW in #139087). This needs a ``@craterbot` check`.
@craterbot check
👌 Experiment pr-142723
created and queued.
🤖 Automatically detected try build 8d46be7
🔍 You can check out the queue and this experiment's details.
i️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more
🚧 Experiment pr-142723
is now running
i️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more
🎉 Experiment pr-142723
is completed!
📊 3143 regressed and 10 fixed (650587 total)
📰 Open the full report.
i️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more
Various versions of epaint
, glyph_brush
, and taffy
seem to account for the vast majority of the breakage. Whatever else we do, it'd probably be worth putting in PRs for those.
@traviscross I don't think we should submit any PRs to those crates until we have agreement that we're prepared to break passing e.g. 2.0
to a method taking Into<f32>
. Because I think the likely response to such a PR is "wait, what?".
We've speculatively submitted PRs before in these kind of cases. Such PRs said, essentially, that the code being changed was relying on something that had become an open question. But I'm happy with whatever the people pushing this forward want to do (or not do) in this regard.
taffy
is actually already fixed from when the impl was breifly added on nightly a year ago (DioxusLabs/taffy#643): all the regressions caused by that crate are from other crates using outdated 0.3.* and 0.4.* versions of it (the fix is in 0.3.19 and 0.4.3 and later).
(I plan to do a full write-up of the Crater run soon, I just haven't had time yet.)
Uh oh!
There was an error while loading. Please reload this page.
Crater run to see what the effects of adding
impl From<f16> for f32
without changing the fallback (a.k.a. things that would be caught by the FCW in #139087). This needs a@craterbot check
.