-
Notifications
You must be signed in to change notification settings - Fork 13.7k
Use -Zmir-opt-level=0 in tests for MIR building #142215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
☔ The latest upstream changes (presumably #145773) made this pull request unmergeable. Please resolve the merge conflicts.
Actually, should this whole test suite run in mir-opt-level=0 unless we specify otherwise? Tests for specific mir passes already do that. Precodegen also specify a level.
It is often surprising that the mir-opt test suite defaults everything to opt-level 4. I'd support such a change.
On this PR in particular, if you still want to push it, r=me after a rebase
d8954d0 to
22cdf21
Compare
rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
r? cjgillot
Gonna wait for CI to pass
@bors r=cjgillot
Rollup of 6 pull requests Successful merges: - #142215 (Use -Zmir-opt-level=0 in tests for MIR building) - #143341 (Mention that casting to *const () is a way to roundtrip with from_raw_parts) - #145078 (Fix wrong cache line size of riscv64) - #145290 (Improve std::fs::read_dir docs) - #145335 (Move WTF-8 code from std into core and alloc) - #145904 (Move `riscv64-gc-unknown-linux-musl` from Tier 2 with Host tools to Tier 2) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of #142215 - saethlin:mir-building-tests, r=cjgillot Use -Zmir-opt-level=0 in tests for MIR building The mir-opt test suite currently defaults all tests in it to `-Zmir-opt-level=4`, so if a test is trying to test MIR _building_ not optimizations and it is in that directory, it _must_ override the default mir-opt-level.
Uh oh!
There was an error while loading. Please reload this page.
The mir-opt test suite currently defaults all tests in it to
-Zmir-opt-level=4, so if a test is trying to test MIR building not optimizations and it is in that directory, it must override the default mir-opt-level.