-
Notifications
You must be signed in to change notification settings - Fork 13.7k
Fix linting false positive when block used as value #141987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment has been minimized.
This comment has been minimized.
b7c2339 to
5fda6c1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and please add a short comment why this is used
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be informative enough?
// Used for tracking parent expressions that would immediately followed
// by block. Storing false here indicates that expression itself is Block
// expression. This is meant for to prevent report false positive cases where
// expressions with stronger block bind being linted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Storing false here indicates that expression itself is Block expression.
that's for the current impl, I think storing false should mean: while we may be inside of an expression which has a trailing block expression, there exists an expression between that one and the current which acts like a block, but may also be a function call or a try-block
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we also need this for unused parens:
#![allow(unused)] #![warn(unused_parens)] struct Foo; fn main() { loop { if break (Foo) {} }; }
please add this as a test, also test if fn_call({ return }) {}. This should lint (i.e. recursing into function calls should update followed_by_block to false
same for try { { return } }. In general, anything that "wraps" its nested expr should set followed_by_block to false
@rustbot author
Reminder, once the PR becomes ready for a review, use @rustbot ready.
☔ The latest upstream changes (presumably #144469) made this pull request unmergeable. Please resolve the merge conflicts.
Uh oh!
There was an error while loading. Please reload this page.
Fix #141783.