Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix broken link to rustc_type_ir module in serialization docs #141870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
davidjsonn wants to merge 0 commits into rust-lang:master from davidjsonn:master
Closed

Fix broken link to rustc_type_ir module in serialization docs #141870

davidjsonn wants to merge 0 commits into rust-lang:master from davidjsonn:master

Conversation

Copy link
Contributor

@davidjsonn davidjsonn commented Jun 1, 2025

PR fixes a broken link in the Rust compiler documentation. The original link pointed to rustc_type_ir/codec.rs, which no longer exists in the current compiler architecture. This functionality has been moved to the rustc_middle crate.

The change updates the broken link:

Copy link
Collaborator

rustbot commented Jun 1, 2025

r? @fee1-dead

rustbot has assigned @fee1-dead.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-rustc-dev-guide Area: rustc-dev-guide S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 1, 2025
Copy link
Collaborator

rustbot commented Jun 1, 2025

The rustc-dev-guide subtree was changed. If this PR only touches the dev guide consider submitting a PR directly to rust-lang/rustc-dev-guide otherwise thank you for updating the dev guide with your changes.

cc @BoxyUwU, @jieyouxu, @Kobzol

Copy link
Member

r=me and errs once the suggestion is applied.

@fee1-dead fee1-dead added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 4, 2025
Copy link
Contributor Author

What would you suggest doing?

Copy link
Member

errs gave a suggestion in his review

Copy link
Contributor Author

done, thank you!

Copy link
Member

@bors r=fee1-dead,compiler-errors rollup

Copy link
Collaborator

bors commented Jun 5, 2025

📌 Commit 38fd777 has been approved by fee1-dead,compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 5, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jun 5, 2025
...piler-errors
Fix broken link to rustc_type_ir module in serialization docs
PR fixes a broken link in the Rust compiler documentation. The original link pointed to `rustc_type_ir/codec.rs`, which no longer exists in the current compiler architecture. This functionality has been moved to the `rustc_middle` crate.
The change updates the broken link:
- From: https://doc.rust-lang.org/nightly/nightly-rustc/src/rustc_type_ir/codec.rs.html#21
- To: https://doc.rust-lang.org/nightly/nightly-rustc/rustc_middle/index.html 
bors added a commit that referenced this pull request Jun 5, 2025
Rollup of 8 pull requests
Successful merges:
 - #140638 (UnsafePinned: also include the effects of UnsafeCell)
 - #141272 (modularize the config module bootstrap)
 - #141777 (Do not run PGO/BOLT in x64 Linux alt builds)
 - #141870 (Fix broken link to rustc_type_ir module in serialization docs)
 - #141938 (update rust offload bootstrap)
 - #141962 (rustc-dev-guide subtree update)
 - #141965 (`tests/ui`: A New Order [3/N])
 - #141970 (implement new `x` flag: `--skip-std-check-if-no-download-rustc`)
r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compiler-errors compiler-errors compiler-errors left review comments

Labels
A-rustc-dev-guide Area: rustc-dev-guide S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /