-
Notifications
You must be signed in to change notification settings - Fork 13.7k
Add read_buf equivalents for positioned reads
#140459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+308
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@rustbot
rustbot
added
O-unix
Operating system: Unix-like
O-windows
Operating system: Windows
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
labels
Apr 29, 2025
This comment has been minimized.
This comment has been minimized.
@niklasf
niklasf
force-pushed
the
feature/read-buf-at
branch
from
April 29, 2025 14:07
74e016c to
2ccb45f
Compare
Have these changes been discussed with libs-api at all? Usually changes to unstable API need to be proposed at https://github.com/rust-lang/libs-team/ with the ACP issue template.
This needs some tests as well.
For the above,
@rustbot author
@rustbot
rustbot
added
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
May 1, 2025
Reminder, once the PR becomes ready for a review, use @rustbot ready.
4 tasks
For consistency and clarity, could we include safety comments on each unsafe block? Even brief notes are helpful to understand the assumptions being made
@niklasf
niklasf
force-pushed
the
feature/read-buf-at
branch
from
May 12, 2025 21:45
2ccb45f to
09ac65a
Compare
This comment has been minimized.
This comment has been minimized.
@niklasf
niklasf
force-pushed
the
feature/read-buf-at
branch
from
May 12, 2025 22:06
09ac65a to
a22d2b4
Compare
This comment has been minimized.
This comment has been minimized.
@niklasf
niklasf
force-pushed
the
feature/read-buf-at
branch
from
May 12, 2025 22:30
a22d2b4 to
59cb58e
Compare
This comment has been minimized.
This comment has been minimized.
@niklasf
niklasf
force-pushed
the
feature/read-buf-at
branch
from
May 12, 2025 22:41
59cb58e to
85e1da1
Compare
Thank you both.
- Opened an APC that was accepted, but items to be added under a new feature instead of
read_buf. Moved toread_buf_atwith new tracking issue Tracking Issue forread_buf_at#140771 . - Added safety comments also for FFI calls.
- Added tests.
@rustbot ready
@rustbot
rustbot
added
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
May 12, 2025
@bors try
bors
added a commit
that referenced
this pull request
May 28, 2025
Add `read_buf` equivalents for positioned reads Adds the following items under the ~~`read_buf` (#78485)~~ `read_buf_at` (#140771) feature: - `std::os::unix::fs::FileExt::read_buf_at` - `std::os::unix::fs::FileExt::read_buf_exact_at` - `std::os::windows::fs::FileExt::seek_read_buf` try-job: x86_64-msvc-1 try-job: x86_64-msvc-2
@niklasf
niklasf
force-pushed
the
feature/read-buf-at
branch
from
August 18, 2025 20:10
bf491a1 to
55ce5c1
Compare
Back after a while, rebased to resolve conflicts, and ready for the next round of review.
@rustbot ready
@rustbot
rustbot
added
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Aug 18, 2025
This comment has been minimized.
This comment has been minimized.
@niklasf
niklasf
force-pushed
the
feature/read-buf-at
branch
from
August 18, 2025 20:31
55ce5c1 to
bf491a1
Compare
tgross35
tgross35
requested changes
Sep 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates, two small nits then r=me
@rustbot
rustbot
added
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Sep 3, 2025
@niklasf
niklasf
force-pushed
the
feature/read-buf-at
branch
from
September 3, 2025 18:29
bf491a1 to
60c69e1
Compare
Adds the following items under the `read_buf_at` feature: - `std::os::unix::fs::FileExt::read_buf_at` - `std::os::unix::fs::FileExt::read_buf_exact_at` - `std::os::windows::fs::FileExt::seek_read_buf`
@niklasf
niklasf
force-pushed
the
feature/read-buf-at
branch
from
September 3, 2025 18:43
60c69e1 to
c914c47
Compare
@rustbot ready
@rustbot
rustbot
added
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Sep 3, 2025
tgross35
tgross35
approved these changes
Sep 3, 2025
Going to rerun the try job just in case, but LGTM. Thanks for the updates
@bors2 try
rust-bors bot
added a commit
that referenced
this pull request
Sep 3, 2025
Add `read_buf` equivalents for positioned reads try-job: `x86_64-msvc*` try-job: `test-various*` try-job: `dist-various*`
This comment has been minimized.
This comment has been minimized.
@bors r+
@bors
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Sep 3, 2025
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Sep 4, 2025
...oss35 Add `read_buf` equivalents for positioned reads Adds the following items under the ~~`read_buf` (rust-lang#78485)~~ `read_buf_at` (rust-lang#140771) feature: - `std::os::unix::fs::FileExt::read_buf_at` - `std::os::unix::fs::FileExt::read_buf_exact_at` - `std::os::windows::fs::FileExt::seek_read_buf` try-job: `x86_64-msvc*` try-job: `test-various*` try-job: `dist-various*`
bors
added a commit
that referenced
this pull request
Sep 4, 2025
Rollup of 24 pull requests Successful merges: - #140459 (Add `read_buf` equivalents for positioned reads) - #143725 (core: add Peekable::next_if_map) - #145209 (Stabilize `path_add_extension`) - #145342 (fix drop scope for `super let` bindings within `if let`) - #145750 (raw_vec.rs: Remove superfluous fn alloc_guard) - #145827 (On unused binding or binding not present in all patterns, suggest potential typo of unit struct/variant or const) - #145932 (Allow `inline(always)` with a target feature behind a unstable feature `target_feature_inline_always`.) - #145962 (Ensure we emit an allocator shim when only some crate types need one) - #145963 (Add LSX accelerated implementation for source file analysis) - #146054 (add `#[must_use]` to `array::repeat`) - #146090 (Derive `PartialEq` for `InvisibleOrigin`) - #146112 (don't uppercase error messages) - #146120 (Correct typo in `rustc_errors` comment) - #146124 (Test `rustc-dev` in `distcheck`) - #146127 (Rename `ToolRustc` to `ToolRustcPrivate`) - #146131 (rustdoc-search: add test case for indexing every item type) - #146134 (llvm: nvptx: Layout update to match LLVM) - #146136 (docs(std): add missing closing code block fences in doc comments) - #146137 (Disallow frontmatter in `--cfg` and `--check-cfg` arguments) - #146140 (compiletest: cygwin follows windows in using PATH for dynamic libraries) - #146150 (fix(rustdoc): match rustc `--emit` precedence ) - #146155 (Make bootstrap self test parallel) - #146161 ([rustdoc] Uncomment code to add scraped rustdoc examples in loaded paths) - #146172 (triagebot: configure some pings when certain attributes are used) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Sep 4, 2025
Rollup merge of #140459 - niklasf:feature/read-buf-at, r=tgross35 Add `read_buf` equivalents for positioned reads Adds the following items under the ~~`read_buf` (#78485)~~ `read_buf_at` (#140771) feature: - `std::os::unix::fs::FileExt::read_buf_at` - `std::os::unix::fs::FileExt::read_buf_exact_at` - `std::os::windows::fs::FileExt::seek_read_buf` try-job: `x86_64-msvc*` try-job: `test-various*` try-job: `dist-various*`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Adds the following items under the
(削除)read_buf(#78485) (削除ここまで)read_buf_at(#140771) feature:std::os::unix::fs::FileExt::read_buf_atstd::os::unix::fs::FileExt::read_buf_exact_atstd::os::windows::fs::FileExt::seek_read_buftry-job:
x86_64-msvc*try-job:
test-various*try-job:
dist-various*