Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

dirfd: preliminary unix and windows implementations #139514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Qelxiros wants to merge 1 commit into rust-lang:master
base: master
Choose a base branch
Loading
from Qelxiros:120426-dirfd

Conversation

Copy link
Contributor

@Qelxiros Qelxiros commented Apr 8, 2025 •
edited by rustbot
Loading

Tracking issue: #120426

As per this comment, this issue needs someone to start work on an implementation, so I've implemented a couple functions for UNIX. There's a lot more work to be done here (most of the feature), so I'd love some guidance on what needs fixing in this PR and any notes on how to proceed. Thanks!

try-job: x86_64-msvc*
try-job: test-various*
try-job: dist-various*

Copy link
Collaborator

rustbot commented Apr 8, 2025

r? @workingjubilee

rustbot has assigned @workingjubilee.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 8, 2025

This comment has been minimized.

Copy link
Member

r? libs

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 1, 2025
Copy link
Collaborator

bors commented May 3, 2025

☔ The latest upstream changes (presumably #140608) made this pull request unmergeable. Please resolve the merge conflicts.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@Qelxiros Qelxiros changed the title (削除) dirfd: initial quick and dirty implementation for unix (削除ここまで) (追記) dirfd: preliminary unix and windows implementations (追記ここまで) May 6, 2025
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 6, 2025
Copy link
Contributor Author

@tgross35 This has been waiting for a review for two weeks. Should I reroll another reviewer? I'm not sure what the process is here, but I don't want it to slip through the cracks. Is this PR mergeable in it's current state or is there something more I need to implement? Obviously there are more functions in the ACP, but I want to make sure I'm on the right track with what I have.

Copy link
Member

@ChrisDenton ChrisDenton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, quite a lot of us were away for a week+. I can take an initial look at the Windows code.

This comment has been minimized.

Copy link
Contributor Author

All good on the delay, and thanks for the review! Those issues should be good now. As a side note to whoever does the next review, there have been a lot of changes on the unix side too since the last review.

Copy link
Contributor Author

Qelxiros commented Jun 7, 2025

@tgross35 are you able to review this?

@Qelxiros Qelxiros force-pushed the 120426-dirfd branch 3 times, most recently from e9bd439 to beb6937 Compare July 15, 2025 02:43

This comment has been minimized.

Copy link
Collaborator

rustbot commented Jul 15, 2025

Some changes occurred in src/tools/cargo

cc @ehuss

@rustbot rustbot added the A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. label Jul 15, 2025

This comment has been minimized.

Copy link
Contributor Author

@bors2 try

rust-bors bot added a commit that referenced this pull request Jul 15, 2025 
dirfd: preliminary unix and windows implementations
Tracking issue: #120426
As per [this comment](#120426 (comment)), this issue needs someone to start work on an implementation, so I've implemented a couple functions for UNIX. There's a lot more work to be done here (most of the feature), so I'd love some guidance on what needs fixing in this PR and any notes on how to proceed. Thanks!
try-job: `x86_64-msvc*`
try-job: `test-various*`
try-job: `dist-various*`
Copy link

rust-bors bot commented Jul 15, 2025

⌛ Trying commit f62937b with merge c619035...

To cancel the try build, run the command @bors2 try cancel.

Copy link

rust-bors bot commented Jul 15, 2025

☀️ Try build successful (CI)
Build commit: c619035 (c619035542dd8821e9f388f9ebda2ba1c3dec16a, parent: 7f2065a4bae1faed5bab928c670964eafbf43b55)

Copy link
Contributor Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 15, 2025
Copy link
Collaborator

bors commented Aug 18, 2025

☔ The latest upstream changes (presumably #145489) made this pull request unmergeable. Please resolve the merge conflicts.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor Author

@tgross35 are you able to review this? It's been sitting for a while now.

Copy link
Contributor

Sorry about that, this is a moderately complex addition and I haven't had the time to look into it properly. I'll reroll but keep myself assigned as a fallback.

r? libs

@tgross35 tgross35 self-assigned this Aug 27, 2025
Copy link
Collaborator

bors commented Aug 31, 2025

☔ The latest upstream changes (presumably #146043) made this pull request unmergeable. Please resolve the merge conflicts.

Copy link
Collaborator

rustbot commented Sep 1, 2025

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisDenton ChrisDenton ChrisDenton left review comments

@Noratrieb Noratrieb Awaiting requested review from Noratrieb

@tgross35 tgross35 Awaiting requested review from tgross35

@the8472 the8472 Awaiting requested review from the8472

Labels
A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. O-windows Operating system: Windows S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /