Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Add regression test for nested replacement ranges in cfg_eval #139286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
reez12g wants to merge 1 commit into rust-lang:master
base: master
Choose a base branch
Loading
from reez12g:add-regression-test-132727

Conversation

Copy link
Contributor

@reez12g reez12g commented Apr 2, 2025

Closes #132727

Copy link
Collaborator

rustbot commented Apr 2, 2025

r? @fmease

rustbot has assigned @fmease.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 2, 2025
Copy link
Contributor Author

reez12g commented Apr 2, 2025

@rustbot label -S-waiting-on-review +S-waiting-on-author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 2, 2025
Copy link
Contributor Author

reez12g commented Apr 3, 2025

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 3, 2025
@reez12g reez12g marked this pull request as ready for review April 3, 2025 02:25
Copy link
Member

@fmease fmease Apr 3, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just me having a very first glance at this PR and at surrounding context, I'll give this a proper review some other time:

I'm surprised that this test leads to errors (×ばつ "removing an expression is not supported in this position") in nightly-2024年08月15日 which is a few nightlies before PR #128725 (which intro'ed the ICE reported in #129166 (e.g., nightly-2024年09月08日)). Shouldn't it pass in that version to be a proper regression test instead of erroring as in nightly-2024年09月09日?

Copy link
Contributor

Based on this comment, switching to waiting on author to incorporate changes. Feel free to request a review with @rustbot ready, thanks!

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 19, 2025
Copy link
Collaborator

rustbot commented Jun 19, 2025

Reminder, once the PR becomes ready for a review, use @rustbot ready.

Copy link
Member

@reez12g
Thanks for your contribution.
Form wg-triage. Could you please take a look comment above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmease fmease fmease left review comments

Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a regression test for #132587

AltStyle によって変換されたページ (->オリジナル) /