-
Notifications
You must be signed in to change notification settings - Fork 13.7k
Revert "Rollup merge of #136127 - WaffleLapkin:dyn_ptr_unwrap_cast, r=compiler-errors" #138892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@bors r+ rollup=never
☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing ab5b1be to master...
What is this?
This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 10a76d6 (parent) -> ab5b1be (this PR)
Test differences
Show 10 test diffs
Stage 1
[ui] tests/ui/cast/ptr-to-trait-obj-wrap-add-auto.rs: pass -> [missing] (J0)[ui] tests/ui/cast/ptr-to-trait-obj-wrap-different-args.rs: pass -> [missing] (J0)[ui] tests/ui/cast/ptr-to-trait-obj-wrap-different-regions.rs: pass -> [missing] (J0)[ui] tests/ui/cast/ptr-to-trait-obj-wrap.rs: pass -> [missing] (J0)
Stage 2
[ui] tests/ui/cast/ptr-to-trait-obj-wrap-add-auto.rs: pass -> [missing] (J1)[ui] tests/ui/cast/ptr-to-trait-obj-wrap-different-args.rs: pass -> [missing] (J1)[ui] tests/ui/cast/ptr-to-trait-obj-wrap-different-regions.rs: pass -> [missing] (J1)[ui] tests/ui/cast/ptr-to-trait-obj-wrap.rs: pass -> [missing] (J1)
Additionally, 2 doctest diffs were found. These are ignored, as they are noisy.
Job group index
- J0:
x86_64-gnu-llvm-18-3,x86_64-gnu-llvm-19-3 - J1:
aarch64-apple,aarch64-gnu,arm-android,armhf-gnu,dist-i586-gnu-i586-i686-musl,i686-gnu-1,i686-gnu-nopt-1,i686-msvc-1,test-various,x86_64-apple-2,x86_64-gnu,x86_64-gnu-llvm-18-1,x86_64-gnu-llvm-18-2,x86_64-gnu-llvm-19-1,x86_64-gnu-llvm-19-2,x86_64-gnu-nopt,x86_64-gnu-stable,x86_64-mingw-1,x86_64-msvc-1
Job duration changes
aarch64-apple: 4091.3s -> 5033.9s (23.0%)dist-aarch64-apple: 5499.4s -> 6459.9s (17.5%)aarch64-gnu-debug: 5957.1s -> 6324.8s (6.2%)dist-i686-mingw: 7932.3s -> 8328.2s (5.0%)dist-i586-gnu-i586-i686-musl: 5106.1s -> 5305.9s (3.9%)x86_64-mingw-1: 8953.3s -> 9217.7s (3.0%)x86_64-gnu-llvm-18-1: 5404.5s -> 5561.8s (2.9%)dist-aarch64-msvc: 8445.9s -> 8674.1s (2.7%)i686-gnu-nopt-2: 6435.1s -> 6606.3s (2.7%)dist-i686-linux: 5968.7s -> 6115.7s (2.5%)
How to interpret the job duration changes?
Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.
Only noticed the notification now; thanks for working on fixing up my broken stuff, errs 💚
@WaffleLapkin: Hope to fix it fully soon. Thanks for the initial approach, and sorry that we had to revert it due to stupid things like perf >.<
...not permanently tho. Just until we can land something like #138542, which will fix the underlying perf issues (#136127 (comment)). I just don't want this to land on beta and have people rely on this behavior if it'll need some reworking for it to be implemented performantly.
r? @WaffleLapkin or reassign -- sorry for reverting ur pr! i'm working on getting it re-landed soon :>