-
Notifications
You must be signed in to change notification settings - Fork 13.8k
use implied bounds compat mode in MIR borrowck #120123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
84151c3 to
31c44b8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you just make 4 revisions in normalization-nested? lifetime or param x compat or non-comat?
@bors rollup=never p=1
r=me, preferably with the new test combined into the previous with revisions (and confirmation that the bevy regression is covered)
31c44b8 to
058ab53
Compare
@bors r=jackh726
use implied bounds compat mode in MIR borrowck cc - rust-lang#119956 - rust-lang#118553 This should hopefully fix bevy 🤔 `cargo test` ends up freezing my computer though, cargo build went from err to ok however 😁 r? `@jackh726`
💔 Test failed - checks-actions
Identified as spurious network error.
@bors retry
☀️ Test successful - checks-actions
Approved by: jackh726
Pushing 88189a7 to master...
|
Finished benchmarking commit (88189a7): comparison URL. Overall result: ❌✅ regressions and improvements - ACTION NEEDEDNext Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Bootstrap: 664.714s -> 663.584s (-0.17%) |
# Objective - Using the latest nightly for `miri` is generally desirable as we want to catch regressions upstream or new problems quickly - rust-lang/rust#120123 should be merged now, so it should work. ## Solution - Revert #11421. --------- Co-authored-by: François <mockersf@gmail.com> Co-authored-by: Alice Cecile <alice.i.cecil@gmail.com>
Wins outweigh the losses, but wg-grammar has been behaving frantically lately, anyway.
@rustbot label: +perf-regression-triaged
cc
-Zno-implied-bounds-compat#119956This should hopefully fix bevy 🤔
cargo testends up freezing my computer though, cargo build went from err to ok however 😁r? @jackh726