-
Notifications
You must be signed in to change notification settings - Fork 13.7k
[perf only] Reimplement references debuginfo as projection. #119471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
r? @b-naber
(rustbot has picked a reviewer for you, use r? to override)
r? @ghost
@bors try @rust-timer queue
This comment has been minimized.
This comment has been minimized.
Failed to set assignee to ghost
: invalid assignee
Note: Only org members with at least the repository "read" role, users with write permissions, or people who have commented on the PR may be assigned.
[perf only] Reimplement references debuginfo as projection. This PR is not meant to be merged: it completely breaks debuginfo, as LLVM does not support implicit pointers in debuginfo yet.
This comment has been minimized.
This comment has been minimized.
☀️ Try build successful - checks-actions
Build commit: bda8139 (bda81399917ca5f3bc11a38a3bb119f53c6541d7
)
This comment has been minimized.
This comment has been minimized.
Finished benchmarking commit (bda8139): comparison URL. Overall result: ❌✅ regressions and improvements - ACTION NEEDEDBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @bors rollup=never Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Bootstrap: 667.255s -> 665.75s (-0.23%) |
4679331
to
36fae9e
Compare
@bors try @rust-timer queue
This comment has been minimized.
This comment has been minimized.
[perf only] Reimplement references debuginfo as projection. This PR is not meant to be merged: it completely breaks debuginfo, as LLVM does not support implicit pointers in debuginfo yet.
The job x86_64-gnu-llvm-17
failed! Check out the build log: (web) (plain)
Click to see the possible cause of the failure (guessed by this bot)
#16 exporting to docker image format
#16 sending tarball 29.0s done
#16 DONE 41.1s
##[endgroup]
Setting extra environment values for docker: --env ENABLE_GCC_CODEGEN=1 --env GCC_EXEC_PREFIX=/usr/lib/gcc/
[CI_JOB_NAME=x86_64-gnu-llvm-17]
---
sccache: Starting the server...
##[group]Configure the build
configure: processing command line
configure:
configure: build.configure-args := ['--build=x86_64-unknown-linux-gnu', '--llvm-root=/usr/lib/llvm-17', '--enable-llvm-link-shared', '--set', 'rust.thin-lto-import-instr-limit=10', '--set', 'change-id=99999999', '--enable-verbose-configure', '--enable-sccache', '--disable-manage-submodules', '--enable-locked-deps', '--enable-cargo-native-static', '--set', 'rust.codegen-units-std=1', '--set', 'dist.compression-profile=balanced', '--dist-compression-formats=xz', '--disable-dist-src', '--release-channel=nightly', '--enable-debug-assertions', '--enable-overflow-checks', '--enable-llvm-assertions', '--set', 'rust.verify-llvm-ir', '--set', 'rust.codegen-backends=llvm,cranelift,gcc', '--set', 'llvm.static-libstdcpp', '--enable-new-symbol-mangling']
configure: target.x86_64-unknown-linux-gnu.llvm-config := /usr/lib/llvm-17/bin/llvm-config
configure: llvm.link-shared := True
configure: rust.thin-lto-import-instr-limit := 10
configure: change-id := 99999999
---
.........................
failures:
---- [mir-opt] tests/mir-opt/pre-codegen/checked_ops.rs stdout ----
4 debug x => _1;
5 debug n => _2;
6 let mut _0: u32;
- scope 1 (inlined <u32 as Step>::forward) {
- debug start => _1;
- debug n => _2;
- let _8: std::option::Option<u32>;
- scope 2 {
- }
- scope 3 (inlined <u32 as Step>::forward_checked) {
- debug start => _1;
- debug n => _2;
- scope 4 {
- debug n => _3;
- scope 6 (inlined core::num::<impl u32>::checked_add) {
- debug self => _1;
- debug rhs => _3;
- let mut _7: bool;
- scope 7 {
- debug a => _5;
- debug b => _6;
- }
- scope 8 (inlined core::num::<impl u32>::overflowing_add) {
- debug self => _1;
- debug rhs => _3;
- let mut _4: (u32, bool);
- let _5: u32;
- let _6: bool;
- scope 9 {
- debug a => _5;
- debug b => _6;
- }
- }
- }
- }
- scope 5 (inlined convert::num::ptr_try_from_impls::<impl TryFrom<usize> for u32>::try_from) {
- debug value => _2;
- let mut _3: u32;
- }
- }
- scope 10 (inlined Option::<u32>::is_none) {
- debug (*(self: &Option<u32>)) => _8;
- scope 11 (inlined Option::<u32>::is_some) {
- debug (*(self: &Option<u32>)) => _8;
- }
- }
- scope 12 (inlined core::num::<impl u32>::wrapping_add) {
- debug self => _1;
- debug rhs => _3;
- }
55
56 bb0: {
- StorageLive(_3);
- StorageLive(_3);
- StorageLive(_8);
- _3 = _2 as u32 (IntToInt);
- StorageLive(_5);
- StorageLive(_6);
- StorageLive(_4);
- _4 = CheckedAdd(_1, _3);
- _5 = (_4.0: u32);
- _6 = (_4.1: bool);
- StorageDead(_4);
- StorageLive(_7);
- _7 = unlikely(move _6) -> [return: bb1, unwind unreachable];
+ _0 = <u32 as Step>::forward(move _1, move _2) -> [return: bb1, unwind continue];
70
71 bb1: {
- switchInt(move _7) -> [0: bb2, otherwise: bb3];
-
- bb2: {
- _8 = Option::<u32>::Some(_5);
- StorageDead(_7);
- StorageDead(_7);
- StorageDead(_6);
- StorageDead(_5);
- StorageDead(_8);
- goto -> bb4;
- }
-
- bb3: {
- _8 = const Option::<u32>::None;
- StorageDead(_7);
- StorageDead(_6);
- StorageDead(_5);
- StorageDead(_8);
- assert(!const true, "attempt to compute `{} + {}`, which would overflow", const core::num::<impl u32>::MAX, const 1_u32) -> [success: bb4, unwind continue];
-
- bb4: {
- bb4: {
- _0 = Add(_1, _3);
- StorageDead(_3);
97 }
- }
-
-
- ALLOC0 (size: 8, align: 4) {
- 00 00 00 00 __ __ __ __ │ ....░░░░
103
thread '[mir-opt] tests/mir-opt/pre-codegen/checked_ops.rs' panicked at src/tools/compiletest/src/runtest.rs:4357:21:
thread '[mir-opt] tests/mir-opt/pre-codegen/checked_ops.rs' panicked at src/tools/compiletest/src/runtest.rs:4357:21:
Actual MIR output differs from expected MIR output /checkout/tests/mir-opt/pre-codegen/checked_ops.step_forward.PreCodegen.after.mir
failures:
[mir-opt] tests/mir-opt/pre-codegen/checked_ops.rs
☀️ Try build successful - checks-actions
Build commit: 7490ccd (7490ccd9e62d099f4cd387beead1413388281619
)
This comment has been minimized.
This comment has been minimized.
Finished benchmarking commit (7490ccd): comparison URL. Overall result: ❌✅ regressions and improvements - ACTION NEEDEDBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @bors rollup=never Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Bootstrap: 667.569s -> 663.649s (-0.59%) |
This PR is not meant to be merged: it completely breaks debuginfo, as LLVM does not support implicit pointers in debuginfo yet.