-
Notifications
You must be signed in to change notification settings - Fork 13.8k
Rustc infer doctest #106523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rustc infer doctest #106523
Conversation
r? @estebank
(rustbot has picked a reviewer for you, use r? to override)
Some changes occurred in need_type_info.rs
cc @lcnr
r? jyn514
@rustbot label: +A-testsuite
Sorry for the long wait. I won't have time for reviews for the foreseeable future.
As a note, this has many of the changes from #106574.
r? @Nilstrieb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The docs say that this shouldn't compile, so there's something wrong here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you need any help with figuring this out, feel free to open a thread in the t-compiler/help stream on zulip
@CarsonV any updates on this?
@Dylan-DPC I got busy/ was partially waiting to see if the duplicate work was finished faster than I could. I missed the response from jyn and Nilstrieb with feedback. Sorry about that! Did not mean to waste everyone's time. I will get back into this tonight or tomorrow night
☔ The latest upstream changes (presumably #106621) made this pull request unmergeable. Please resolve the merge conflicts.
This was subsumed by #106486, closing it. Thank you for the PR anyways!
More efforts towards #99144. Made some assumptions as I was going along but wanted to get eyes on them now so I can learn before moving on towards completing the rest of the missing doctests.