Commit 015c777

committed

Auto merge of #142432 - matthiaskrgr:rollup-ziuls9y, r=matthiaskrgr

Rollup of 6 pull requests Successful merges: - #138016 (Added `Clone` implementation for `ChunkBy`) - #141162 (refactor `AttributeGate` and `rustc_attr!` to emit notes during feature checking) - #141474 (Add `ParseMode::Diagnostic` and fix multiline spans in diagnostic attribute lints) - #141947 (Specify that "option-like" enums must be `#[repr(Rust)]` to be ABI-compatible with their non-1ZST field.) - #142252 (Improve clarity of `core::sync::atomic` docs about "Considerations" in regards to CAS operations) - #142337 (miri: add flag to suppress float non-determinism) r? `@ghost` `@rustbot` modify labels: rollup

2 parents ed44c0e + 88df5a5 commit 015c777Copy full SHA for 015c777

File tree

49 files changed

+907

-594

lines changed

compiler
- rustc_ast_passes/src
  - feature_gate.rs
- rustc_feature/src
  - builtin_attrs.rs
  - lib.rs
- rustc_lint
  - messages.ftl
  - src
- rustc_parse_format/src
  - lib.rs
  - tests.rs
- rustc_session/src
  - parse.rs
- rustc_trait_selection/src/error_reporting/traits
library
- alloctests/tests
  - slice.rs
- core/src
  - primitive_docs.rs
  - slice
    - iter.rs
  - sync
    - atomic.rs
src/tools/miri
- README.md
- src
  - bin
    - miri.rs
  - eval.rs
  - intrinsics
    - mod.rs
    - simd.rs
  - machine.rs
  - math.rs
  - operator.rs
tests/ui
- consts
  - gate-do-not-const-check.rs
  - gate-do-not-const-check.stderr
- diagnostic_namespace
  - multiline_spans.rs
  - multiline_spans.stderr
  - on_unimplemented
    - broken_format.rs
    - broken_format.stderr
- feature-gates
- force-inlining
  - gate.rs
  - gate.stderr
- on-unimplemented
  - feature-gate-on-unimplemented.rs
  - feature-gate-on-unimplemented.stderr
- rustdoc
  - feature-gate-doc_primitive.rs
  - feature-gate-doc_primitive.stderr
- tool-attributes
  - diagnostic_item.rs
  - diagnostic_item.stderr
- traits/default-method
  - rustc_must_implement_one_of_gated.rs
  - rustc_must_implement_one_of_gated.stderr

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

49 files changed

+907

-594

lines changed

`‎compiler/rustc_ast_passes/src/feature_gate.rs‎`

Lines changed: 12 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -36,6 +36,16 @@ macro_rules! gate_alt {`
`36`	`36`	`feature_err(&$visitor.sess, $name, $span, $explain).emit();`
`37`	`37`	`}`
`38`	`38`	`}};`
	`39`	`+ ($visitor:expr, $has_feature:expr, $name:expr, $span:expr, $explain:expr, $notes: expr) => {{`
	`40`	`+ if !$has_feature && !$span.allows_unstable($name) {`
	`41`	`+ #[allow(rustc::untranslatable_diagnostic)] // FIXME: make this translatable`
	`42`	`+ let mut diag = feature_err(&$visitor.sess, $name, $span, $explain);`
	`43`	`+ for note in $notes {`
	`44`	`+ diag.note(*note);`
	`45`	`+ }`
	`46`	`+ diag.emit();`
	`47`	`+ }`
	`48`	`+ }};`
`39`	`49`	`}`
`40`	`50`
`41`	`51`	`/// The case involving a multispan.`
`@@ -154,11 +164,11 @@ impl<'a> Visitor<'a> for PostExpansionVisitor<'a> {`
`154`	`164`	`let attr_info = attr.ident().and_then(\|ident\| BUILTIN_ATTRIBUTE_MAP.get(&ident.name));`
`155`	`165`	`// Check feature gates for built-in attributes.`
`156`	`166`	`if let Some(BuiltinAttribute {`
`157`		`- gate: AttributeGate::Gated(_, name, descr, has_feature),`
	`167`	`+ gate: AttributeGate::Gated{ feature, message, check, notes, .. },`
`158`	`168`	`..`
`159`	`169`	`}) = attr_info`
`160`	`170`	`{`
`161`		`- gate_alt!(self, has_feature(self.features), name, attr.span, descr);`
	`171`	`+ gate_alt!(self, check(self.features), feature, attr.span, message,*notes);`
`162`	`172`	`}`
`163`	`173`	// Check unstable flavors of the `#[doc]` attribute.
`164`	`174`	`if attr.has_name(sym::doc) {`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit 015c777

File tree

49 files changed

Some content is hidden

49 files changed

`‎compiler/rustc_ast_passes/src/feature_gate.rs‎`

0 commit comments