Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Commit ed44c0e

Browse files
committed
Auto merge of #142353 - workingjubilee:warn-less-about-cdecl-and-other-abis, r=ChrisDenton,RalfJung
compiler: Ease off the accelerator on `unsupported_calling_conventions` This is to give us more time to discuss #142330 without the ecosystem having an anxiety attack. I have withdrawn `unsupported_calling_conventions` from report-in-deps I believe we should consider this a simple suspension of the decision in #141435 to start this process, rather than a reversal. That is, we may continue with linting again. But I believe we are about to get a... reasonable amount of feedback just from currently available information and should allow ourselves time to process it.
2 parents bb3a3c5 + 9f50246 commit ed44c0e

File tree

9 files changed

+13
-370
lines changed

9 files changed

+13
-370
lines changed

‎compiler/rustc_lint_defs/src/builtin.rs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3664,7 +3664,7 @@ declare_lint! {
36643664
"use of unsupported calling convention",
36653665
@future_incompatible = FutureIncompatibleInfo {
36663666
reason: FutureIncompatibilityReason::FutureReleaseError,
3667-
report_in_deps: true,
3667+
report_in_deps: false,
36683668
reference: "issue #137018 <https://github.com/rust-lang/rust/issues/137018>",
36693669
};
36703670
}

‎tests/ui/abi/unsupported.aarch64.stderr‎

Lines changed: 0 additions & 48 deletions
Original file line numberDiff line numberDiff line change
@@ -368,42 +368,6 @@ LL | fn stdcall_ptr(f: extern "stdcall" fn()) {
368368
= note: for more information, see issue #130260 <https://github.com/rust-lang/rust/issues/130260>
369369
= note: `#[warn(unsupported_fn_ptr_calling_conventions)]` on by default
370370

371-
Future breakage diagnostic:
372-
warning: use of calling convention not supported on this target
373-
--> $DIR/unsupported.rs:131:17
374-
|
375-
LL | fn cdecl_ptr(f: extern "cdecl" fn()) {
376-
| ^^^^^^^^^^^^^^^^^^^
377-
|
378-
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
379-
= note: for more information, see issue #137018 <https://github.com/rust-lang/rust/issues/137018>
380-
= help: use `extern "C"` instead
381-
= note: `#[warn(unsupported_calling_conventions)]` on by default
382-
383-
Future breakage diagnostic:
384-
warning: use of calling convention not supported on this target
385-
--> $DIR/unsupported.rs:136:1
386-
|
387-
LL | extern "cdecl" {}
388-
| ^^^^^^^^^^^^^^^^^
389-
|
390-
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
391-
= note: for more information, see issue #137018 <https://github.com/rust-lang/rust/issues/137018>
392-
= help: use `extern "C"` instead
393-
= note: `#[warn(unsupported_calling_conventions)]` on by default
394-
395-
Future breakage diagnostic:
396-
warning: use of calling convention not supported on this target
397-
--> $DIR/unsupported.rs:139:1
398-
|
399-
LL | extern "cdecl-unwind" {}
400-
| ^^^^^^^^^^^^^^^^^^^^^^^^
401-
|
402-
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
403-
= note: for more information, see issue #137018 <https://github.com/rust-lang/rust/issues/137018>
404-
= help: use `extern "C-unwind"` instead
405-
= note: `#[warn(unsupported_calling_conventions)]` on by default
406-
407371
Future breakage diagnostic:
408372
warning: the calling convention "vectorcall" is not supported on this target
409373
--> $DIR/unsupported.rs:145:22
@@ -437,15 +401,3 @@ LL | fn cmse_entry_ptr(f: extern "C-cmse-nonsecure-entry" fn()) {
437401
= note: for more information, see issue #130260 <https://github.com/rust-lang/rust/issues/130260>
438402
= note: `#[warn(unsupported_fn_ptr_calling_conventions)]` on by default
439403

440-
Future breakage diagnostic:
441-
warning: use of calling convention not supported on this target
442-
--> $DIR/unsupported.rs:128:1
443-
|
444-
LL | extern "cdecl" fn cdecl() {}
445-
| ^^^^^^^^^^^^^^^^^^^^^^^^^
446-
|
447-
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
448-
= note: for more information, see issue #137018 <https://github.com/rust-lang/rust/issues/137018>
449-
= help: use `extern "C"` instead
450-
= note: `#[warn(unsupported_calling_conventions)]` on by default
451-

‎tests/ui/abi/unsupported.arm.stderr‎

Lines changed: 0 additions & 48 deletions
Original file line numberDiff line numberDiff line change
@@ -336,42 +336,6 @@ LL | fn stdcall_ptr(f: extern "stdcall" fn()) {
336336
= note: for more information, see issue #130260 <https://github.com/rust-lang/rust/issues/130260>
337337
= note: `#[warn(unsupported_fn_ptr_calling_conventions)]` on by default
338338

339-
Future breakage diagnostic:
340-
warning: use of calling convention not supported on this target
341-
--> $DIR/unsupported.rs:131:17
342-
|
343-
LL | fn cdecl_ptr(f: extern "cdecl" fn()) {
344-
| ^^^^^^^^^^^^^^^^^^^
345-
|
346-
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
347-
= note: for more information, see issue #137018 <https://github.com/rust-lang/rust/issues/137018>
348-
= help: use `extern "C"` instead
349-
= note: `#[warn(unsupported_calling_conventions)]` on by default
350-
351-
Future breakage diagnostic:
352-
warning: use of calling convention not supported on this target
353-
--> $DIR/unsupported.rs:136:1
354-
|
355-
LL | extern "cdecl" {}
356-
| ^^^^^^^^^^^^^^^^^
357-
|
358-
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
359-
= note: for more information, see issue #137018 <https://github.com/rust-lang/rust/issues/137018>
360-
= help: use `extern "C"` instead
361-
= note: `#[warn(unsupported_calling_conventions)]` on by default
362-
363-
Future breakage diagnostic:
364-
warning: use of calling convention not supported on this target
365-
--> $DIR/unsupported.rs:139:1
366-
|
367-
LL | extern "cdecl-unwind" {}
368-
| ^^^^^^^^^^^^^^^^^^^^^^^^
369-
|
370-
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
371-
= note: for more information, see issue #137018 <https://github.com/rust-lang/rust/issues/137018>
372-
= help: use `extern "C-unwind"` instead
373-
= note: `#[warn(unsupported_calling_conventions)]` on by default
374-
375339
Future breakage diagnostic:
376340
warning: the calling convention "vectorcall" is not supported on this target
377341
--> $DIR/unsupported.rs:145:22
@@ -405,15 +369,3 @@ LL | fn cmse_entry_ptr(f: extern "C-cmse-nonsecure-entry" fn()) {
405369
= note: for more information, see issue #130260 <https://github.com/rust-lang/rust/issues/130260>
406370
= note: `#[warn(unsupported_fn_ptr_calling_conventions)]` on by default
407371

408-
Future breakage diagnostic:
409-
warning: use of calling convention not supported on this target
410-
--> $DIR/unsupported.rs:128:1
411-
|
412-
LL | extern "cdecl" fn cdecl() {}
413-
| ^^^^^^^^^^^^^^^^^^^^^^^^^
414-
|
415-
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
416-
= note: for more information, see issue #137018 <https://github.com/rust-lang/rust/issues/137018>
417-
= help: use `extern "C"` instead
418-
= note: `#[warn(unsupported_calling_conventions)]` on by default
419-

‎tests/ui/abi/unsupported.riscv32.stderr‎

Lines changed: 0 additions & 48 deletions
Original file line numberDiff line numberDiff line change
@@ -336,42 +336,6 @@ LL | fn stdcall_ptr(f: extern "stdcall" fn()) {
336336
= note: for more information, see issue #130260 <https://github.com/rust-lang/rust/issues/130260>
337337
= note: `#[warn(unsupported_fn_ptr_calling_conventions)]` on by default
338338

339-
Future breakage diagnostic:
340-
warning: use of calling convention not supported on this target
341-
--> $DIR/unsupported.rs:131:17
342-
|
343-
LL | fn cdecl_ptr(f: extern "cdecl" fn()) {
344-
| ^^^^^^^^^^^^^^^^^^^
345-
|
346-
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
347-
= note: for more information, see issue #137018 <https://github.com/rust-lang/rust/issues/137018>
348-
= help: use `extern "C"` instead
349-
= note: `#[warn(unsupported_calling_conventions)]` on by default
350-
351-
Future breakage diagnostic:
352-
warning: use of calling convention not supported on this target
353-
--> $DIR/unsupported.rs:136:1
354-
|
355-
LL | extern "cdecl" {}
356-
| ^^^^^^^^^^^^^^^^^
357-
|
358-
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
359-
= note: for more information, see issue #137018 <https://github.com/rust-lang/rust/issues/137018>
360-
= help: use `extern "C"` instead
361-
= note: `#[warn(unsupported_calling_conventions)]` on by default
362-
363-
Future breakage diagnostic:
364-
warning: use of calling convention not supported on this target
365-
--> $DIR/unsupported.rs:139:1
366-
|
367-
LL | extern "cdecl-unwind" {}
368-
| ^^^^^^^^^^^^^^^^^^^^^^^^
369-
|
370-
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
371-
= note: for more information, see issue #137018 <https://github.com/rust-lang/rust/issues/137018>
372-
= help: use `extern "C-unwind"` instead
373-
= note: `#[warn(unsupported_calling_conventions)]` on by default
374-
375339
Future breakage diagnostic:
376340
warning: the calling convention "vectorcall" is not supported on this target
377341
--> $DIR/unsupported.rs:145:22
@@ -405,15 +369,3 @@ LL | fn cmse_entry_ptr(f: extern "C-cmse-nonsecure-entry" fn()) {
405369
= note: for more information, see issue #130260 <https://github.com/rust-lang/rust/issues/130260>
406370
= note: `#[warn(unsupported_fn_ptr_calling_conventions)]` on by default
407371

408-
Future breakage diagnostic:
409-
warning: use of calling convention not supported on this target
410-
--> $DIR/unsupported.rs:128:1
411-
|
412-
LL | extern "cdecl" fn cdecl() {}
413-
| ^^^^^^^^^^^^^^^^^^^^^^^^^
414-
|
415-
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
416-
= note: for more information, see issue #137018 <https://github.com/rust-lang/rust/issues/137018>
417-
= help: use `extern "C"` instead
418-
= note: `#[warn(unsupported_calling_conventions)]` on by default
419-

‎tests/ui/abi/unsupported.riscv64.stderr‎

Lines changed: 0 additions & 48 deletions
Original file line numberDiff line numberDiff line change
@@ -336,42 +336,6 @@ LL | fn stdcall_ptr(f: extern "stdcall" fn()) {
336336
= note: for more information, see issue #130260 <https://github.com/rust-lang/rust/issues/130260>
337337
= note: `#[warn(unsupported_fn_ptr_calling_conventions)]` on by default
338338

339-
Future breakage diagnostic:
340-
warning: use of calling convention not supported on this target
341-
--> $DIR/unsupported.rs:131:17
342-
|
343-
LL | fn cdecl_ptr(f: extern "cdecl" fn()) {
344-
| ^^^^^^^^^^^^^^^^^^^
345-
|
346-
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
347-
= note: for more information, see issue #137018 <https://github.com/rust-lang/rust/issues/137018>
348-
= help: use `extern "C"` instead
349-
= note: `#[warn(unsupported_calling_conventions)]` on by default
350-
351-
Future breakage diagnostic:
352-
warning: use of calling convention not supported on this target
353-
--> $DIR/unsupported.rs:136:1
354-
|
355-
LL | extern "cdecl" {}
356-
| ^^^^^^^^^^^^^^^^^
357-
|
358-
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
359-
= note: for more information, see issue #137018 <https://github.com/rust-lang/rust/issues/137018>
360-
= help: use `extern "C"` instead
361-
= note: `#[warn(unsupported_calling_conventions)]` on by default
362-
363-
Future breakage diagnostic:
364-
warning: use of calling convention not supported on this target
365-
--> $DIR/unsupported.rs:139:1
366-
|
367-
LL | extern "cdecl-unwind" {}
368-
| ^^^^^^^^^^^^^^^^^^^^^^^^
369-
|
370-
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
371-
= note: for more information, see issue #137018 <https://github.com/rust-lang/rust/issues/137018>
372-
= help: use `extern "C-unwind"` instead
373-
= note: `#[warn(unsupported_calling_conventions)]` on by default
374-
375339
Future breakage diagnostic:
376340
warning: the calling convention "vectorcall" is not supported on this target
377341
--> $DIR/unsupported.rs:145:22
@@ -405,15 +369,3 @@ LL | fn cmse_entry_ptr(f: extern "C-cmse-nonsecure-entry" fn()) {
405369
= note: for more information, see issue #130260 <https://github.com/rust-lang/rust/issues/130260>
406370
= note: `#[warn(unsupported_fn_ptr_calling_conventions)]` on by default
407371

408-
Future breakage diagnostic:
409-
warning: use of calling convention not supported on this target
410-
--> $DIR/unsupported.rs:128:1
411-
|
412-
LL | extern "cdecl" fn cdecl() {}
413-
| ^^^^^^^^^^^^^^^^^^^^^^^^^
414-
|
415-
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
416-
= note: for more information, see issue #137018 <https://github.com/rust-lang/rust/issues/137018>
417-
= help: use `extern "C"` instead
418-
= note: `#[warn(unsupported_calling_conventions)]` on by default
419-

‎tests/ui/abi/unsupported.x64.stderr‎

Lines changed: 0 additions & 48 deletions
Original file line numberDiff line numberDiff line change
@@ -315,42 +315,6 @@ LL | fn stdcall_ptr(f: extern "stdcall" fn()) {
315315
= note: for more information, see issue #130260 <https://github.com/rust-lang/rust/issues/130260>
316316
= note: `#[warn(unsupported_fn_ptr_calling_conventions)]` on by default
317317

318-
Future breakage diagnostic:
319-
warning: use of calling convention not supported on this target
320-
--> $DIR/unsupported.rs:131:17
321-
|
322-
LL | fn cdecl_ptr(f: extern "cdecl" fn()) {
323-
| ^^^^^^^^^^^^^^^^^^^
324-
|
325-
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
326-
= note: for more information, see issue #137018 <https://github.com/rust-lang/rust/issues/137018>
327-
= help: use `extern "C"` instead
328-
= note: `#[warn(unsupported_calling_conventions)]` on by default
329-
330-
Future breakage diagnostic:
331-
warning: use of calling convention not supported on this target
332-
--> $DIR/unsupported.rs:136:1
333-
|
334-
LL | extern "cdecl" {}
335-
| ^^^^^^^^^^^^^^^^^
336-
|
337-
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
338-
= note: for more information, see issue #137018 <https://github.com/rust-lang/rust/issues/137018>
339-
= help: use `extern "C"` instead
340-
= note: `#[warn(unsupported_calling_conventions)]` on by default
341-
342-
Future breakage diagnostic:
343-
warning: use of calling convention not supported on this target
344-
--> $DIR/unsupported.rs:139:1
345-
|
346-
LL | extern "cdecl-unwind" {}
347-
| ^^^^^^^^^^^^^^^^^^^^^^^^
348-
|
349-
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
350-
= note: for more information, see issue #137018 <https://github.com/rust-lang/rust/issues/137018>
351-
= help: use `extern "C-unwind"` instead
352-
= note: `#[warn(unsupported_calling_conventions)]` on by default
353-
354318
Future breakage diagnostic:
355319
warning: the calling convention "C-cmse-nonsecure-call" is not supported on this target
356320
--> $DIR/unsupported.rs:153:21
@@ -373,15 +337,3 @@ LL | fn cmse_entry_ptr(f: extern "C-cmse-nonsecure-entry" fn()) {
373337
= note: for more information, see issue #130260 <https://github.com/rust-lang/rust/issues/130260>
374338
= note: `#[warn(unsupported_fn_ptr_calling_conventions)]` on by default
375339

376-
Future breakage diagnostic:
377-
warning: use of calling convention not supported on this target
378-
--> $DIR/unsupported.rs:128:1
379-
|
380-
LL | extern "cdecl" fn cdecl() {}
381-
| ^^^^^^^^^^^^^^^^^^^^^^^^^
382-
|
383-
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
384-
= note: for more information, see issue #137018 <https://github.com/rust-lang/rust/issues/137018>
385-
= help: use `extern "C"` instead
386-
= note: `#[warn(unsupported_calling_conventions)]` on by default
387-

0 commit comments

Comments
(0)

AltStyle によって変換されたページ (->オリジナル) /