Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add ENOTCAPABLE for macOS#4925

Open
Thomasdezeeuw wants to merge 1 commit intorust-lang:main from
Thomasdezeeuw:macos-ENOTCAPABLE
Open

Add ENOTCAPABLE for macOS #4925
Thomasdezeeuw wants to merge 1 commit intorust-lang:main from
Thomasdezeeuw:macos-ENOTCAPABLE

Conversation

@Thomasdezeeuw
Copy link
Contributor

@Thomasdezeeuw Thomasdezeeuw commented Jan 12, 2026

Description

Adds the ENOTCAPABLE constant. Also updates ELAST to 107 since a new error was added.

Sources

Checklist

  • Relevant tests in libc-test/semver have been updated
  • No placeholder or unstable values like *LAST or *MAX are
    included (see #3131)
  • Tested locally (cd libc-test && cargo test --target mytarget);
    especially relevant for platforms that may not be checked in CI

@rustbot label +stable-nominated

Also updates ELAST to 107 since a new error was added.
@rustbot rustbot added O-macos O-unix S-waiting-on-review stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Jan 12, 2026
Copy link
Contributor Author

I was also wondering if ELAST should be deleted? But since it exists already it might be a breaking change?

Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs updates given the CI failure.

Which macos version is xnu-12377.1.9? If it is MacOS 26, GHA should support that now, and you could send a PR bumping it. Otherwise you can add a skip in libc-test/build.rs, but the CI bump would be much preferred.

Copy link
Collaborator

rustbot commented Jan 12, 2026

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@rustbot rustbot added the A-CI Area: CI-related items label Jan 13, 2026
Copy link
Contributor Author

Push a commit to update the CI. One issue is that it doesn't seem that macOS 26 is supported on x86_64, so I didn't update the intel runner in

os: macos-15-intel
.

Copy link
Contributor Author

With the update of macOS the CI now starts to fail:

 bad `HOST_VM_INFO64_COUNT` value at byte 0: rust: 38 (0x26) != c 40 (0x28)
 rust bytes: 26 00 00 00
 c bytes: 28 00 00 00
bad `vm_statistics64_data_t` size: rust: 152 != c 160
bad `vm_statistics64` size: rust: 152 != c 160
size of `vm_statistics64_data_t` is 160 in C and 152 in Rust
size of `struct vm_statistics64` is 160 in C and 152 in Rust

So we need #4926 as well, or ignore it somehow. I didn't see the HOST_VM_INFO64_COUNT failure locally oddly enough.

Copy link
Member

I was also wondering if ELAST should be deleted? But since it exists already it might be a breaking change?

Yeah, it should be removed in 1.0.

So we only can add ENOTCAPABLE on 0.2 as any other things would be a breaking change, a solution here is moving things other than ENOTCAPABLE addiction (and test skip) to #4926, ship this on 0.2, then introduce breaking changes on 1.0 with #4926.

Copy link
Contributor

Could you do the CI bump in a separate PR? To keep things that are required from that separate from new API.

JohnTitor reacted with thumbs up emoji

Copy link
Contributor Author

Thomasdezeeuw commented Jan 15, 2026
edited
Loading

Could you do the CI bump in a separate PR?

That will mean the CI will fail, see my comment here: #4925 (comment). But I'm happy to do it.

Copy link
Contributor

Yeah that's expected, bumping CI typically requires a few commits to update changed values like that. Getting that through before doing any brand new API just makes things simpler.

Copy link
Contributor Author

I've dropped the CI commit (with a force push).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tgross35 tgross35 tgross35 requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

A-CI Area: CI-related items O-macos O-unix S-waiting-on-author stable-nominated This PR should be considered for cherry-pick to libc's stable release branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Comments

AltStyle によって変換されたページ (->オリジナル) /