-
Notifications
You must be signed in to change notification settings - Fork 45
Remove parsing of __ in title strings, fixes #53 #54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I had a user of Starlark get really confused by the missing __ recently. Anything we can do to get this merged?
I don't think this library is currently maintained.
I consider it maintained at low velocity. I plan to look into this issue over the weekend.
jshort
commented
Nov 28, 2022
I'm affected by this too so I'd love to see this merged!
harupy
commented
Jul 26, 2023
@zbraniecki I'm also affected by this. Can we merge this PR?
Hi, I want to ask when will this PR be merged? I have encountered the same issue. We have developed a language compiler
KCL that uses this library, and when the user-defined variable __b cannot be found, it is displayed as b in the error message, which is confusing.
zertosh
commented
Oct 25, 2023
Please consider merging this
Apologies for radio silence and thank you for the PR.
This feature has been added to support text style annotation based on the source, but I'm not sure if it's useful anymore.
zertosh
commented
Oct 26, 2023
@zbraniecki, no worries. Much appreciated. Any chance you can get a release out? Thank you :)
Summary: PR was merged: rust-lang/annotate-snippets-rs#54 Easier to keep track of by pointing to an upstream rev rather than a fork. Reviewed By: ndmitchell, shayne-fletcher Differential Revision: D50743702 fbshipit-source-id: f9a58c4901f85e0b489e5785a8137e2ffc477884
Summary: PR was merged: rust-lang/annotate-snippets-rs#54 Easier to keep track of by pointing to an upstream rev rather than a fork. Reviewed By: ndmitchell, shayne-fletcher Differential Revision: D50743702 fbshipit-source-id: f9a58c4901f85e0b489e5785a8137e2ffc477884
Summary: PR was merged: rust-lang/annotate-snippets-rs#54 Easier to keep track of by pointing to an upstream rev rather than a fork. Reviewed By: ndmitchell, shayne-fletcher Differential Revision: D50743702 fbshipit-source-id: f9a58c4901f85e0b489e5785a8137e2ffc477884
Summary: rust-lang/annotate-snippets-rs#54 was released as `annotate-snippets-0.9.2`. There are no new changes here, just that we're pulling from crates.io. Reviewed By: capickett Differential Revision: D51218745 fbshipit-source-id: 2195771458b7578606f71b3b413a2813e5843f24
Summary: rust-lang/annotate-snippets-rs#54 was released as `annotate-snippets-0.9.2`. There are no new changes here, just that we're pulling from crates.io. Reviewed By: capickett Differential Revision: D51218745 fbshipit-source-id: 2195771458b7578606f71b3b413a2813e5843f24
Summary: rust-lang/annotate-snippets-rs#54 was released as `annotate-snippets-0.9.2`. There are no new changes here, just that we're pulling from crates.io. Reviewed By: capickett Differential Revision: D51218745 fbshipit-source-id: 2195771458b7578606f71b3b413a2813e5843f24
In #53 I reported the issue that
__in titles gets parsed specially. This feature isn't documented anywhere, and doing a bit of git archaeology, I get lost 4 years ago with phrases like "more tests" adding the code. I can't figure out why someone would want this feature, but assume there was a reason when it was added, however, I'm not sure it is still useful. There doesn't seem any way to opt out of this feature, and as a result, error messages containing__get dropped (which is super confusing).In the absence of feedback as the right way to proceed, I've made a diff removing the feature entirely. The alternative would be to document the feature, explain why it's useful, and explain how to avoid it (an alternative API? an escaping scheme?).