One of my small gripes with Rust is that it doesn't have keyword arguments (yet?). That would make passing these boolean options much more understandable at the call sites. I'm not sure if there's currently a clearer way?

keyword arguments

you can always create structs with appropriate field names ;)

Replaced the magic constant.

@zbraniecki what are your feelings regarding the change of the api of the DisplayListFormatter constructor? I feel like it's still fine when passing two booleans. If there turns out to be a need for more configuration, it could be changed later?

If there turns out to be a need for more configuration, it could be changed later?

Yep, it's an internal API, I'm fine with adjusting it later.

I wonder...

@bors r+

I guess not

Thanks! I think this will also need a new release before it can be used in rustc, right?

@zbraniecki (or someone else?) could you push a new version to crates.io?

yeah, will do.

done. 0.6.0 released.

@phansch did you intend to turn also context lines (without numbers) to LL?

I see this:

error[E0003]: Expected token: "="
 --> ../fluent-bundle/examples/resources/en-US/simple.ftl:2:18
 |
2 | input-parse-error Error: Could not parse input `{ $input }`. Reason: { $reason }
 | ^^ Expected token: "="
 |
-----------------------------

turned into:

error[E0003]: Expected token: "="
 --> ../fluent-bundle/examples/resources/en-US/simple.ftl:2:18
LL |
LL | input-parse-error Error: Could not parse input `{ $input }`. Reason: { $reason }
LL | ^^ Expected token: "="
LL |
-----------------------------

I think I'd expect:

error[E0003]: Expected token: "="
 --> ../fluent-bundle/examples/resources/en-US/simple.ftl:2:18
 |
LL | input-parse-error Error: Could not parse input `{ $input }`. Reason: { $reason }
 | ^^ Expected token: "="
 |
-----------------------------

instead.

Yeah I noticed that, too. That's a bug of the current implementation. My current plan is to only show LL for DisplaySourceLine::Content and where DisplayLine::Source has a lineno set. I think that should be enough?

(I've been a bit time restricted the past month or so but I want to get back into it again this month)