-
-
Notifications
You must be signed in to change notification settings - Fork 845
Refactor sentence and fix typo #227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor sentence: "当我们引入全局可用的print!宏在教程03,我门有一点作弊。" -> "我们在教程03引入全局可用的`print!`宏时有一点作弊。" Fix typo: "我门" typo corrected during sentence refactoring
BartMassey
BartMassey
approved these changes
Nov 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a Chinese speaker, but it checks out in Google Translate at least.
Thanks much for the correction.
I'm not a Chinese speaker, but it checks out in Google Translate at least.
Thanks, He correction is correct. CI seems to have failed compilation
@eldruin Can be merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor sentence:
"当我们引入全局可用的
print宏在教程03,我门有一点作弊。"-> "我们在教程03引入全局可用的
print!宏时有一点作弊。"Fix typo:
"我门" typo corrected during sentence refactoring
Related Issue: #166
Pre-commit steps
./contributor_setup.shfollowed by./devtool ready_for_publishRubywithBundlerandNPMinstalled locally../devtool ready_for_publish_no_rustcan be used instead (faster).