Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add VSCode Rust Analyzer Settings #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Copy link
Contributor

@zicklag zicklag commented Apr 28, 2022

Description

Fixes errors reported by rust analyzer due to differing target and a missing cargo feature.

I'm not sure if I'm the only one who ran into this or not, so feel free to close if this shouldn't be needed for some reason!

Pre-commit steps

  • Tested on QEMU and real HW Rasperry Pi.
    • Not needed if it is just a README change or similar.
  • Ran ./contributor_setup.sh followed by ./devtool ready_for_publish
    • You'll need Ruby with Bundler and NPM installed locally.
    • If no Rust-related files were changed, ./devtool ready_for_publish_no_rust can be used instead (faster).
    • This step is optional, but much appreciated if done.

Note: I ran the second step above, and it generated a bunch of changes in the "diff to previous" sections, but the only change was to add a timestamp to all the diffs, which I'm assuming is just a different version of diff on my system, and is tangential to the change this PR makes, so I just didn't commit those files.

@zicklag zicklag force-pushed the feature/rust-analyzer-settings branch 2 times, most recently from 27280f5 to f67e297 Compare April 28, 2022 00:29
Copy link
Member

The individual tutorials have dedicated settings, e.g. https://github.com/rust-embedded/rust-raspberrypi-OS-tutorials/blob/master/17_kernel_symbols/.vscode/settings.json.

99% of the time, I am only opening a dedicated tutorial folder in VS Code, not the entire repo. But I guess it doesn't hurt to have this at the top level as well.
Could you extend your PR so that the added settings file is the same as the one from tutorial 17 linked above?

Fixes errors reported by rust analyzer due to differing target and a
missing cargo feature.
@zicklag zicklag force-pushed the feature/rust-analyzer-settings branch from f67e297 to b8e8ebc Compare April 28, 2022 14:58
Copy link
Contributor Author

zicklag commented Apr 28, 2022

Ah, that makes sense, pushed an update.

@andre-richter andre-richter merged commit cc09970 into rust-embedded:master Apr 28, 2022
Copy link
Member

Thanks!

zicklag reacted with heart emoji

@zicklag zicklag deleted the feature/rust-analyzer-settings branch April 28, 2022 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /