-
Notifications
You must be signed in to change notification settings - Fork 269
Expand embedded_io::ErrorKind to better match std::io::ErrorKind#698
Draft
Oakchris1955 wants to merge 1 commit into
Draft
Expand embedded_io::ErrorKind to better match std::io::ErrorKind #698Oakchris1955 wants to merge 1 commit into
Oakchris1955 wants to merge 1 commit into
Conversation
Oakchris1955
commented
Sep 8, 2025
Contributor
Author
It seems that these additional ErrorKind variants were stabilized with Rust 1.83.0, so adding them would mean bumping up the msrv. However, since 1.83.0 was released on November 2024, and taking into account that 1.81 is the current msrv, I think that this change is justified
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #648
I am creating this as a draft PR because of this comment stating that this change isn't an urgent one. Furthermore, while I added some
ErrorKindvariants to better matchstd::io::ErrorKind, there might be more that should be added.