-
Notifications
You must be signed in to change notification settings - Fork 434
Added more links to awesome rust projects for the nRF52 series #87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Added NRF52-hal crate to read me
Added Nordic semiconductor links to cargo and repository containing HALs and Board support crates
Hey @sigvartmh, thanks for the contribution!
As one of the maintainers of nrf-rs, it would be nice to link to the https://github.com/nrf-rs organization directly, similar to how stm32-rs is grouped.
Let me know what you think :)
Yup that would be better @jamesmunns awesome stuff maintainig nrf-rs btw keep up the cool work.
Most of the credit goes to @wez and @hannobraun :)
Repo link is dead on the nrf52840 crate, but maybe that's an @wez issue here?
Similar for the nrf52-hal crate but that seems to be that it links to an archived Repo from before the move.
Is this just a limitation of Crates.io I wasn't aware of? I'm in favor of merging this PR and contacting the owners to get this sorted out.
Grouped nrf-rs in the same way as stm32-rs is. Also added the nrf52dk-sys crate to the list
Changed the structure a bit @RandomInsano also added nrf52dk-sys crate if that's okei for @jamesmunns
We're in between transitioning from some old crate and repo names and the new ones in the new org, so we may have some old names mentioned, some new names not yet published, and some stuff may be slightly wrong at the moment. We'll get our ducks in a row and ping this issue when its a bit saner.
README.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrong quotes used here.
README.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://crates.io/crates/nrf52832 does not exist
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for not seeing your PR for that long. Except for the incorrect quotes in that one line and the link to the non-existing crate the PR looks good to me.
@therealprof They are doing major rework on their repository structure and naming so maybe wait with merge until they've finished https://crates.io/keywords/nrf52
@sigvartmh I'm kind of aware since I'm part of that organisation. Would it be okay for you to close this in the meanwhile until the dust has settled?
Will do 👍
No description provided.