Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add WIP driver for AT24Cx Serial EEPROM ICs #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
therealprof merged 1 commit into rust-embedded:master from eldruin:at24cx
Aug 8, 2018

Conversation

Copy link
Member

@eldruin eldruin commented Aug 6, 2018

No description provided.

Copy link
Contributor

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

Copy link
Contributor

@japaric Have you changed something? It says:

Code owner review required
Waiting on code owner review from rahul-thakoor.

Copy link
Contributor

bors r+

bors bot added a commit that referenced this pull request Aug 8, 2018
67: Add WIP driver for AT24Cx Serial EEPROM ICs r=therealprof a=eldruin
Co-authored-by: Diego Barrios Romero <eldruin@gmail.com>
Copy link
Contributor

bors bot commented Aug 8, 2018

Timed out

Copy link
Member

japaric commented Aug 8, 2018

@therealprof I think I messed up the syntax of CODEOWNERS. Hold on.

Copy link
Member

japaric commented Aug 8, 2018

@therealprof OK, it should work now.

@therealprof therealprof merged commit f755c1f into rust-embedded:master Aug 8, 2018
Copy link
Contributor

@japaric Thanks. Are we going to use bors or merge manually as before?

Copy link
Member

japaric commented Aug 8, 2018

Manual merges as there's no Travis CI to run here.

therealprof reacted with thumbs up emoji

@eldruin eldruin deleted the at24cx branch August 8, 2018 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@therealprof therealprof therealprof approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /