-
Notifications
You must be signed in to change notification settings - Fork 434
feat: ✨ Add panic handling section #469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panic_probe?
@berkus
berkus
force-pushed
the
fix/dont-panic
branch
from
November 24, 2024 19:29
9771857 to
8e4f915
Compare
@berkus
berkus
requested review from
RandomInsano,
rahul-thakoor and
a team
as code owners
November 24, 2024 20:56
@berkus
berkus
force-pushed
the
fix/dont-panic
branch
from
November 28, 2024 11:02
8e4f915 to
fff0c89
Compare
@berkus
berkus
force-pushed
the
fix/dont-panic
branch
from
November 28, 2024 11:14
fff0c89 to
f6f5e53
Compare
BartMassey
BartMassey
requested changes
Nov 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks much for the big work of putting this together. I made a few notes: resolve them as you will.
BartMassey
BartMassey
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #179