-
Notifications
You must be signed in to change notification settings - Fork 434
Add embedded-hal-compat #327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@ryankurte
ryankurte
requested review from
berkus,
rahul-thakoor,
RandomInsano and
a team
as code owners
June 16, 2021 21:43
rust-highfive
commented
Jun 16, 2021
(rust-highfive has picked a reviewer for you, use r? to override)
@rust-highfive
rust-highfive
added
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-resources
labels
Jun 16, 2021
eldruin
eldruin
approved these changes
Jun 17, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
bors r+
bors bot
added a commit
that referenced
this pull request
Jun 17, 2021
327: Add embedded-hal-compat r=eldruin a=ryankurte I build a little forward/reverse compatibility layer to run drivers across different HAL versions, there's probably plenty of room for improvement but already finding it pretty useful. Co-authored-by: Ryan <ryankurte@users.noreply.github.com>
Timed out.
bors retry
bors bot
added a commit
that referenced
this pull request
Jun 17, 2021
327: Add embedded-hal-compat r=eldruin a=ryankurte I build a little forward/reverse compatibility layer to run drivers across different HAL versions, there's probably plenty of room for improvement but already finding it pretty useful. Co-authored-by: Ryan <ryankurte@users.noreply.github.com>
Timed out.
ugh, travis...
lol, the travis does nothing, this will be the easiest fix ever, one sec
Let's retry after the swap to GHA
bors retry
Build succeeded:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I build a little forward/reverse compatibility layer to run drivers across different HAL versions, there's probably plenty of room for improvement but already finding it pretty useful.