Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Add section for community chat rooms #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
therealprof merged 1 commit into master from jamesmunns-patch-2
Feb 17, 2020
Merged

Conversation

Copy link
Member

@jamesmunns jamesmunns commented Feb 17, 2020

No description provided.

MabezDev reacted with heart emoji
Copy link

r? @ryankurte

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-resources labels Feb 17, 2020
Copy link
Contributor

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Contributor

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bors r+

Copy link
Contributor

bors bot commented Feb 17, 2020

👎 Rejected by code reviews

Copy link
Contributor

bors r+

Copy link
Contributor

bors bot commented Feb 17, 2020

👎 Rejected by code reviews

Copy link
Contributor

bors r+

Copy link
Contributor

bors bot commented Feb 17, 2020

👎 Rejected by code reviews

Copy link
Contributor

bors r+

Copy link
Contributor

bors bot commented Feb 17, 2020

👎 Rejected by code reviews

@therealprof therealprof merged commit 62346fd into master Feb 17, 2020
@bors bors bot deleted the jamesmunns-patch-2 branch February 17, 2020 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@therealprof therealprof therealprof approved these changes

@berkus berkus Awaiting requested review from berkus berkus is a code owner

@rahul-thakoor rahul-thakoor Awaiting requested review from rahul-thakoor rahul-thakoor is a code owner

@RandomInsano RandomInsano Awaiting requested review from RandomInsano RandomInsano is a code owner

+1 more reviewer

@jamwaffles jamwaffles jamwaffles requested changes

Reviewers whose approvals may not affect merge requirements
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-resources
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /