Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add GD32VF103 chip support crates #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
therealprof merged 4 commits into rust-embedded:master from luojia65:patch-1
Oct 11, 2019
Merged

Add GD32VF103 chip support crates #200

therealprof merged 4 commits into rust-embedded:master from luojia65:patch-1
Oct 11, 2019

Conversation

Copy link
Contributor

@luojia65 luojia65 commented Sep 14, 2019
edited
Loading

This pull request adds PAC and HAL libraries for embedded Rust on GD32VF103.
GD32VF103 is a microcontroller chip produced by GigaDevice Semiconductor Inc. with one Bumblebee RISC-V's RV32IMAC core @108 MHz, up to 128 KiB of Flash and 32 KiB of SRAM.
This chip will be in market on late September this year along with its development board Longan Nano (by Sipeed); it's Rust support is under rapid development to provide appropriate ecosystem.

GD32VF103 is a microcontroller chip produced by GigaDevice Semiconductor Inc. with one RISC-V's RV32IMAC core as well as up to 128 KiB of Flash and 32 KiB of SRAM; this chip will be in market on late September this year.
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @RandomInsano (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-resources labels Sep 14, 2019
Copy link
Member

Disasm commented Sep 14, 2019

I don't think it's "awesome" enough: at least I haven't seen anyone running any code on this chip.

Copy link
Contributor Author

luojia65 commented Sep 15, 2019
edited
Loading

@Disasm
Video provided by officials (SPI-bus TFT screen playing Bad Apple): http://cloud.video.taobao.com/play/u/2200606237318/p/2/e/6/t/3/234813091013.mp4
Uploaded photos to example project https://github.com/luojia65/example-gd32vf103 (under development)

Co-Authored-By: Daniel Egger <daniel@eggers-club.de>
Copy link
Contributor

@Disasm
Video provided by officials (SPI-bus TFT screen playing Bad Apple): http://cloud.video.taobao.com/play/u/2200606237318/p/2/e/6/t/3/234813091013.mp4
Uploaded photos to example project https://github.com/luojia65/example-gd32vf103 (under development)

The "not awesome enough" remark was most likely not meant for the hardware but for the Rust implementation of it. ;)

Disasm reacted with thumbs up emoji

Copy link
Contributor Author

Okay, close by now ... (will reopen after full project finished)

Copy link
Member

Disasm commented Oct 7, 2019

@luojia65 sorry, I missed this example. I'm ok with merging this with "(WIP)" remark to improve visibility.

Disasm
Disasm previously approved these changes Oct 8, 2019
Copy link
Contributor

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@therealprof therealprof merged commit c5681dd into rust-embedded:master Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@therealprof therealprof therealprof approved these changes

@berkus berkus Awaiting requested review from berkus berkus is a code owner

@rahul-thakoor rahul-thakoor Awaiting requested review from rahul-thakoor rahul-thakoor is a code owner

@RandomInsano RandomInsano Awaiting requested review from RandomInsano RandomInsano is a code owner

+1 more reviewer

@Disasm Disasm Disasm approved these changes

Reviewers whose approvals may not affect merge requirements
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-resources
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /