-
Notifications
You must be signed in to change notification settings - Fork 434
Merge two lists #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge two lists #12
Conversation
@berkus Wow!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@berkus Would you please address the identified items?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@japaric Marked this as outdated and I don't think there're plans to resurrect this so it should probably not show up in the list.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably not live under Device crates but under a separate category since it does not fit the description above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sounds very weird and I don't think it is accurate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we add communication channels we should probably start with the official ones.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe it's important to give newcomers an easy way to find help and support, so communications channels can stay.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree we should have communication channels there. It's just a bit odd if there's only one git repo and a russian only telegram channel added. If anything we should start will all the official ones and then add the specials.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just couldn't find any other official channels except irc channel.
Perhaps there's also a gitter chat? That should be suitable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should not mention @berkus. Should be defined by the WG and signed-off.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be removed. Anyone is very welcome to contribute and all pull requests will be considered independent of the commit message.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it really make sense to have this badge without actually being mentioned on the list?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It makes sense when we submit it to the list, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually I checked with the list and there're two different badges. One if you think you're awesome and one if you're mentioned. So I withdraw my comment. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅
I will address the comments in a separate PR tonight.
This PR proposes to merge changes from the original community awesome-embedded-rust list.
It's split in more or less logical commits.
Logo rendering should become normal once it lands in master (or we could remove the logo altogether, however i'd vote for keeping it).
The text changes in the list of crates are made with the assumption than this list is supposed to benefit not only hardcode lowlevel rust devs but mostly newcomers who will use this list to discover new things so more detailed descriptions (even if sometimes rather redundant) will make it easier for them to navigate.
Code of conduct and contibution guidelines files added as per rules of the awesome.re awesome list aggregator.