-
Notifications
You must be signed in to change notification settings - Fork 66
Determine rustc version and add it to the report#81
Determine rustc version and add it to the report #81TheTechRobo wants to merge 7 commits intorust-cli:master from
Conversation
bjorn3
commented
Aug 18, 2022
Cargo also sets the RUSTC env var to the path to rustc. cargo -vV may not match rustc -vV. Especially when using a locally built toolchain using rustup toolchain link as in that case the default cargo (which is probably an official version) will be combined with the local rustc which in most cases has a huge version skew.
TheTechRobo
commented
Aug 18, 2022
Cargo also sets the RUSTC env var to the path to rustc.
Did not know that! I'll update that right now.
TheTechRobo
commented
Aug 18, 2022
@bjorn3 - getting this issue:
Compiling human-panic v1.0.4-alpha.0 (/home/thetechrobo/human-panic)
error: environment variable `RUSTC` not defined
--> /home/thetechrobo/human-panic/build.rs:6:22
|
6 | let cargo_path = env!("RUSTC");
| ^^^^^^^^^^^^^
|
= note: this error originates in the macro `env` (in Nightly builds, run with -Z macro-backtrace for more info)
error: could not compile `human-panic` due to previous error
I'm on nightly.
bjorn3
commented
Aug 18, 2022
You should use std::env::var("RUSTC").unwrap() instead. RUSTC is passed at runtime of the build script, but not at compile time.
TheTechRobo
commented
Aug 18, 2022
@bjorn3 - All done.
@bjorn3
bjorn3
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM apart from one nit. Do note that I am not a member of this org, so you will have to wait on someone who is to review and merge.
TheTechRobo
commented
Aug 18, 2022
Should I rebase this PR, or are the maintainers fine with 7 (maybe more later if there's more review) commits?
bjorn3
commented
Aug 18, 2022
It probably won't hurt to squash. No idea what the maintainers prefer though.
TheTechRobo
commented
Mar 15, 2023
I'll probably have time to rebase this on Sunday.
Uh oh!
There was an error while loading. Please reload this page.
This is a 🙋 feature.
Checklist
Context
Fixes #31
Semver Changes
Major release - it changes the
Reportstruct. I don't think 2.0 is released yet, so that would fit perfectly!I have very little experience contributing to Rust crates, so if I made any mistakes, let me know!