-
Notifications
You must be signed in to change notification settings - Fork 66
Comments
chore: Test fix for #109, run in full in CI#110
Open
dead-claudia wants to merge 1 commit intorust-cli:master from
Open
chore: Test fix for #109, run in full in CI #110dead-claudia wants to merge 1 commit intorust-cli:master from
dead-claudia wants to merge 1 commit intorust-cli:master from
Conversation
@dead-claudia
dead-claudia
force-pushed
the
patch-2
branch
2 times, most recently
from
June 13, 2023 15:35
3469629 to
5634427
Compare
Contributor
Author
dead-claudia
commented
Jun 13, 2023
Don't merge this unless tests pass.
@dead-claudia
dead-claudia
changed the title
(削除) chore: update tests to check for #109, run in full in ci (削除ここまで)
(追記) chore: Test fix for #109, run in full in CI (追記ここまで)
Jun 13, 2023
The other tests only needed modified to fix a column number. The action was mysteriously only running one of the tests - I've fixed that. This should help prevent regressions for rust-cli#109 and possibly others. I've verified they also failed prior to that patch.
@dead-claudia
dead-claudia
force-pushed
the
patch-2
branch
from
June 13, 2023 15:39
5634427 to
0b4c9ae
Compare
Contributor
Author
I am not at all sure what's going on with Ubuntu. That step is passing for me in Debian 11 WSL:
$ cargo test --all
Finished test [unoptimized + debuginfo] target(s) in 0.03s
Running unittests src/main.rs (target/debug/deps/custom_panic_test-878234e7f7cc63d3)
running 0 tests
test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s
Running tests/integration.rs (target/debug/deps/integration-68bf49e3a4f9858e)
running 2 tests
test release ... ignored
test debug ... ok
test result: ok. 1 passed; 0 failed; 1 ignored; 0 measured; 0 filtered out; finished in 0.00s
Running unittests src/lib.rs (target/debug/deps/human_panic-da53dffe375e1a86)
running 0 tests
test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s
Running unittests src/main.rs (target/debug/deps/name_collision_test-f7afd69bf803d44c)
running 0 tests
test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s
Running tests/integration.rs (target/debug/deps/integration-7ea103528d2884f8)
running 2 tests
test release ... ignored
test debug ... ok
test result: ok. 1 passed; 0 failed; 1 ignored; 0 measured; 0 filtered out; finished in 0.00s
Running unittests src/main.rs (target/debug/deps/single_panic_test-cc5dc4b4081ab14a)
running 0 tests
test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s
Running tests/integration.rs (target/debug/deps/integration-d4e5e21018f78c23)
running 2 tests
test release ... ignored
test debug ... ok
test result: ok. 1 passed; 0 failed; 1 ignored; 0 measured; 0 filtered out; finished in 0.00s
Doc-tests human-panic
running 1 test
test src/lib.rs - setup_panic (line 94) ... ok
test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.75s
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The other tests only needed modified to fix a column number. The action was mysteriously only running one of the tests - I've fixed that.
This should help prevent regressions for #109 and possibly others. I've verified they also failed prior to that patch.