feat: Adding support for `no_std` environments for `env_filter`#378

Open

WolverinDEV wants to merge 2 commits intorust-cli:main from

WolverinDEV:feature/filter-no_std

Open

feat: Adding support for `no_std` environments for `env_filter` #378
WolverinDEV wants to merge 2 commits intorust-cli:main from
WolverinDEV:feature/filter-no_std

Conversation

@WolverinDEV

Copy link

@WolverinDEV WolverinDEV commented Aug 22, 2025

Using env_logger in a no_std environment may not seem useful at first. However, the env_filter crate is very convenient for defining complex filters that can then be implemented by a custom no_std-compatible logger.

This approach leverages the convenience developers are already familiar with from env_logger, while enabling the same flexibility in no_std contexts with other logging backends.

WolverinDEV added 2 commits

August 22, 2025 03:05

@WolverinDEV


 refactor(filter): Add support for no_std environments

799fa34

Signed-off-by: WolverinDEV <git@did.science>

@WolverinDEV


 refactor(filter): Removed std dependency from log crate

a7ba807

@epage epage added the breaking-change label

Aug 22, 2025

epage

epage reviewed

Aug 22, 2025

View reviewed changes

crates/env_filter/src/parser.rs

Comment on lines +61 to +62

#[cfg(not(feature = "std"))]

impl core::error::Error for ParseError {}

Copy link

Contributor

@epage epage Aug 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes the lack of std require a higher MSRV

epage

epage reviewed

Aug 22, 2025

View reviewed changes

crates/env_filter/src/op.rs

Comment on lines +29 to +35

pub(crate) fn new(spec: &str) -> Result<Self, String> {

Ok(Self {

inner: spec.to_string(),

})

}

pub fn is_match(&self, s: &str) -> bool {

pub(crate) fn is_match(&self, s: &str) -> bool {

Copy link

Contributor

@epage epage Aug 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you split this out into a separate commit?

epage

epage reviewed

Aug 22, 2025

View reviewed changes

crates/env_filter/src/op.rs

Comment on lines +1 to +3

use alloc::string::{String, ToString};

use core::fmt;

Copy link

Contributor

@epage epage Aug 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you group these?

epage

epage reviewed

Aug 22, 2025

View reviewed changes

crates/env_filter/src/parser.rs

Comment on lines +1 to 10

use alloc::borrow::ToOwned;

use alloc::format;

use alloc::string::String;

use alloc::vec::Vec;

use core::fmt::{Display, Formatter};

use log::LevelFilter;

use std::error::Error;

use std::fmt::{Display, Formatter};

use crate::Directive;

use crate::FilterOp;

Copy link

Contributor

@epage epage Aug 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're changing grouping, could you do

use {core,alloc,std}
use third-party
use crate

epage

epage reviewed

Aug 22, 2025

View reviewed changes

crates/env_filter/src/filter.rs

Comment on lines +1 to 10

use alloc::borrow::ToOwned;

use alloc::string::ToString;

use alloc::vec::Vec;

use core::fmt;

use core::mem;

use log::{LevelFilter, Metadata, Record};

use crate::enabled;

Copy link

Contributor

@epage epage Aug 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

epage

epage reviewed

Aug 22, 2025

View reviewed changes

crates/env_filter/Cargo.toml

Comment on lines +34 to +35

log = { version = "0.4.8", default-features = false }

regex = { version = "1.0.3", optional = true, default-features = false, features = ["std", "perf"] }

Copy link

Contributor

@epage epage Aug 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like this belongs in the previous comit, could you move it there?

epage

epage reviewed

Aug 22, 2025

View reviewed changes

crates/env_filter/Cargo.toml

Copy link

Contributor

@epage epage Aug 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

refactor(filter): Add support for no_std environments

Mind fixing your commit type?

A refactor, by definition, has no user facing changes while this does. I would use feat

@coveralls

Copy link

coveralls commented Aug 22, 2025

Pull Request Test Coverage Report for Build 17143312963

Details

1 of 3 (33.33%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 43.914%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
crates/env_filter/src/filter.rs	1	2	50.0%
crates/env_filter/src/parser.rs	0	1	0.0%

Totals	Coverage Status
Change from base Build 16804394720:	0.0%
Covered Lines:	267
Relevant Lines:	608

Conversation

@WolverinDEV WolverinDEV commented Aug 22, 2025

Uh oh!

@epage epage Aug 22, 2025

Choose a reason for hiding this comment

Uh oh!

@epage epage Aug 22, 2025

Choose a reason for hiding this comment

Uh oh!

@epage epage Aug 22, 2025

Choose a reason for hiding this comment

Uh oh!

@epage epage Aug 22, 2025

Choose a reason for hiding this comment

Uh oh!

@epage epage Aug 22, 2025

Choose a reason for hiding this comment

Uh oh!

@epage epage Aug 22, 2025

Choose a reason for hiding this comment

Uh oh!

@epage epage Aug 22, 2025

Choose a reason for hiding this comment

Uh oh!

coveralls commented Aug 22, 2025

Pull Request Test Coverage Report for Build 17143312963

Details

💛 - Coveralls

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Comments