-
Notifications
You must be signed in to change notification settings - Fork 144
feat(fmt)!: Generalize custom formatter to 'RecordFormat' #361
Draft
epage wants to merge 1 commit intorust-cli:main from
Draft
feat(fmt)!: Generalize custom formatter to 'RecordFormat' #361epage wants to merge 1 commit intorust-cli:main from
epage wants to merge 1 commit intorust-cli:main from
Conversation
Pull Request Test Coverage Report for Build 14844590081Details
💛 - Coveralls |
This breaks type inference for basic custom formatters
djugei
commented
May 12, 2025
I have tested a similar change for #363 and i recommend against it.
Too much type info annoyance. I would instead recommend having two separate functions, one for the common case (FormatFn) and one for special needs (RecordFormat)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This breaks type inference for basic custom formatters