Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: Syslog-adapted formating and auto-detection#358

Draft
djugei wants to merge 5 commits intorust-cli:main from
djugei:main
Draft

feat: Syslog-adapted formating and auto-detection #358
djugei wants to merge 5 commits intorust-cli:main from
djugei:main

Conversation

@djugei
Copy link

@djugei djugei commented Mar 30, 2025

closes #357
closes #349

this is a surprisingly low diff size.

Copy link
Contributor

epage commented Mar 31, 2025

From our contrib docs

Already have an idea? It might be good to first create an issue to propose it so we can make sure we are aligned and lower the risk of having to re-work some of it and the discouragement that goes along with that.

Going to mark this as a draft for now.

@epage epage marked this pull request as draft March 31, 2025 17:02
Copy link
Author

djugei commented Mar 31, 2025

Its not really a draft though, it works as is. I am already using it.
Main change i would do is document it better though i do not know where i would best put that info.

Copy link
Contributor

epage commented Mar 31, 2025

We do not have agreement that this solution is in the direction we want to go and so this is only a proposal for demonstrating a direction, regardless of how useful it is to you in the moment. Having this be a draft (or closed) clarifies how this is being treated and pushes discussion on solutions to a single place, the issue.

Copy link
Author

djugei commented Mar 31, 2025

oh, ok so a draft from the project side, i guess that makes sense. i usually see the draft mode used from the contributor side to indicate work-in-progress status.

Copy link
Contributor

epage commented Mar 31, 2025

Yes, but considering we don't yet know what directions this may change, we can't say this is ready for review.

Copy link
Author

djugei commented Apr 9, 2025

i kinda want to slightly alter the log format, right now syslog contains

date host processname[process_id] processname::module:: message

i would like
date host processname[process_id] ::module:: message
better to reduce redundancy.

i am unsure what the easiest way to get the top level binary name is though. then it would be a simple .strip_prefix(name).

Copy link
Author

djugei commented Apr 19, 2025

should be merged after this: #363

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Systemd log format activable via env var better support for logging to syslog

2 participants

Comments

AltStyle によって変換されたページ (->オリジナル) /