-
Notifications
You must be signed in to change notification settings - Fork 108
Adding a send and download to runpod pod cli#266
Closed
justinwlin wants to merge 5 commits intorunpod:main from
Closed
Adding a send and download to runpod pod cli #266justinwlin wants to merge 5 commits intorunpod:main from
justinwlin wants to merge 5 commits intorunpod:main from
Conversation
@justinwlin
justinwlin
force-pushed
the
main
branch
from
January 12, 2024 05:21
a4f4754 to
0514147
Compare
Contributor
justinmerrell
commented
Jan 16, 2024
This is a good idea; I am OK with adding this, I need it to pass the CI/CD checks. You are welcome to take a stab at it, I just won't have time to get around to doing so for a bit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
A common issue I see is with people not having SCP working or trying to get it to work. Yes, I could give them a whole tutorial on SCP. Or I could tell them, at least do this one time, and in the future, you'll never have to do this again.
So I added a SEND / DOWNLOAD command, and tried to add helpful --helps so that people have examples and so that after things are sent it gives them absolute paths and CD commands.
Gave it a try myself, and seems to work well... I just utilized essentially what you guys had from the SSHConnection class 🙏🏼 so feel free to give a try and make corrections if needed.
P.S if this does get merged, can you use the
squash and mergebutton on github this so the commit history is clean ;D. Thanks~