-
Notifications
You must be signed in to change notification settings - Fork 6
feat: cleanup flash deploy/undeploy/build command output format #191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
KAJdev
wants to merge
4
commits into
main
from
zeke/ae-2085-clean-up-flash-undeploy-flash-deploy-formatting
Open
feat: cleanup flash deploy/undeploy/build command output format #191
KAJdev
wants to merge
4
commits into
main
from
zeke/ae-2085-clean-up-flash-undeploy-flash-deploy-formatting
+463
−623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Reduces noise and standardizes output for flash deploy, flash build, and flash undeploy, shifting many internal details to debug logs while presenting clearer, user-focused CLI summaries.
Changes:
- Refactors deploy flow to upload builds separately and deploy via
deploy_from_uploaded_build, printing endpoints/routes and "useful commands". - Simplifies build output and adds a concise build completion summary with artifact location.
- Cleans up undeploy UX to show clearer confirmation + per-endpoint deletion status, while reducing verbose panels and emojis.
Reviewed changes
Copilot reviewed 13 out of 14 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/unit/cli/utils/test_deployment.py | Updates unit tests to cover the new deploy_from_uploaded_build flow. |
| tests/unit/cli/test_undeploy.py | Adjusts undeploy CLI expectations to align with the new help/output behavior. |
| tests/unit/cli/test_deploy.py | Updates deploy command tests for new deployment function + manifest validation call. |
| src/runpod_flash/core/resources/serverless.py | Downgrades noisy operational logs from info/error to debug for cleaner CLI output. |
| src/runpod_flash/core/resources/resource_manager.py | Moves URL/migration/config drift logs to debug to reduce default verbosity. |
| src/runpod_flash/core/resources/network_volume.py | Switches "found existing volume" logging to debug. |
| src/runpod_flash/core/resources/load_balancer_sls_resource.py | Moves LB health/deploy logs from info/error to debug. |
| src/runpod_flash/core/api/runpod.py | Moves several API operation logs to debug (save/delete/check/create). |
| src/runpod_flash/cli/utils/deployment.py | Introduces deploy_from_uploaded_build and reduces console printing during reconcile/provisioning. |
| src/runpod_flash/cli/commands/undeploy.py | Simplifies undeploy output, confirmation, and per-endpoint deletion status presentation. |
| src/runpod_flash/cli/commands/deploy.py | Refactors deploy stages (upload vs deploy), prints endpoints, routes, curl template, and helpful commands. |
| src/runpod_flash/cli/commands/build_utils/manifest.py | Reduces manifest-builder informational logging to debug. |
| src/runpod_flash/cli/commands/build.py | Streamlines build output, adds verbose summary details, and reduces progress UI noise. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleans up the
flash deploy,flash undeploy, andflash buildcommand outputs to be far less noisy and provide relevant information in a cleaner way.Flash deploy now has 4 stages, installing dependencies, creating archive, uploading build, and deploying resources, after which it prints endpoint URLs, routes, a curl template, and relevant env commands.
imageflash build is also far less verbose, but will display the location of the build when it is finished building
imageflash undeploy has been cleaned up and is now a bit more clear about the resources you are deleting, without being too verbose.
image