-
Notifications
You must be signed in to change notification settings - Fork 49
Facebook share button working #152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -20,3 +20,4 @@ | |
| *.swp | ||
|
|
||
| .env | ||
| .idea/* | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,6 +11,10 @@ def display_date(date) | |
| date.to_formatted_s(:long_ordinal) | ||
| end | ||
|
|
||
| def wishlist_url(wishlist) | ||
| request.base_url+"/wishlists/#{wishlist.id}" | ||
| end | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is actually built into Rails, so you can remove this method. As an added bonus, the pre-included method will match your app configuration without extra work (ex. with subdomains, ports, friendly urls/slugs, etc.) Here's a section of the official Rails Guides talking about |
||
|
|
||
| private | ||
|
|
||
| def current_user_pronouns(user, perspectives, capitalize: true) | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| <div class="container"> | ||
| <div class="header"> | ||
| <h2>Create a New Wishlist</h1> | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good catch! 👍 |
||
| <h2>Create a New Wishlist</h2> | ||
|
|
||
| <%= render 'form', wishlist: @wishlist %> | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| SocialShareButton.configure do |config| | ||
| config.allow_sites = %w(twitter email) | ||
| config.allow_sites = %w(facebook twitter email) | ||
| end |