Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Comments

Don't leak a global variable#249

Open
etiennebarrie wants to merge 1 commit intorubychan:master from
etiennebarrie:dont-leak-global-variable
Open

Don't leak a global variable #249
etiennebarrie wants to merge 1 commit intorubychan:master from
etiennebarrie:dont-leak-global-variable

Conversation

@etiennebarrie
Copy link

@etiennebarrie etiennebarrie commented May 7, 2020

While debugging in a pry console, I noticed there was a $DEBUG_BEFORE global variable and I tracked it down to here.

It's not necessary to use a global variable to store the previous value of $DEBUG. Since it's in the same scope, a local variable is enough.

Copy link

Code Climate has analyzed commit 8813276 and detected 0 issues on this pull request.

View more on Code Climate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

AltStyle によって変換されたページ (->オリジナル) /