-
Notifications
You must be signed in to change notification settings - Fork 113
Comments
Make the code in scanner/groovy.rb robust.#228
Open
junaruga wants to merge 1 commit intorubychan:master from
Open
Make the code in scanner/groovy.rb robust. #228junaruga wants to merge 1 commit intorubychan:master from
junaruga wants to merge 1 commit intorubychan:master from
Conversation
Contributor
Author
This report is by a static code analysis tool in our company (Maybe Coverity Scan).
Member
korny
commented
Feb 23, 2019
Mmh. I don’t think there’s really a bug here, since I never got an error with the current version even with thorough testing (see the scanner test suite). While I agree with the first change, the second one would slow down the scanner. I don’t think we need such checks unless someone can actually produce an error here :)
Contributor
Author
junaruga
commented
Feb 24, 2019
Sure, @korny . I respect your decision. It's up to you.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix small issues for
lib/coderay/scanners/groovy.rb.inline_block_paren_depthis initialized asnil.But the code
inline_block_paren_depth += 1,inline_block_paren_depth -= 1,inline_block_paren_depth == 0has a possibility to raise unintendedNoMethodError.It looks good to initialize
inline_block_paren_depthis initialized as0or add checks before the codes.string_delimitercan benilas a possibility. Adding checks looks better.