-
Notifications
You must be signed in to change notification settings - Fork 113
Comments
Update JS idents to match ECMA 5.1#174
Open
JasonBarnabe wants to merge 1 commit intorubychan:master from
Open
Update JS idents to match ECMA 5.1 #174JasonBarnabe wants to merge 1 commit intorubychan:master from
JasonBarnabe wants to merge 1 commit intorubychan:master from
Conversation
Author
JasonBarnabe
commented
Apr 18, 2015
@korny can you look at this?
Member
korny
commented
Apr 22, 2015
Problem is, your solution would only work with Ruby 1.9+. I plan to drop 1.8 support, but not before CodeRay 2.
I think it's safe to drop Ruby 1.8 at this point.
Ruby 1.8 is not even supported for security fixes.
Currently, 2.3 is the oldest Ruby version still supported for security fixes (until April 2019)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.