-
-
Notifications
You must be signed in to change notification settings - Fork 97
Safely evaluate parents and path for orphan nodes.#81
Open
edlebert wants to merge 2 commits intorubycdp:main from
Open
Safely evaluate parents and path for orphan nodes. #81edlebert wants to merge 2 commits intorubycdp:main from
edlebert wants to merge 2 commits intorubycdp:main from
Conversation
It's possible for Cuprite to evaluate the parents or the path for a node that no longer belongs to the document.
Member
route
commented
Apr 22, 2019
@edlebert could you describe scenario when it is possible? Looks like also there'a at least one failing test in all builds
Member
route
commented
Jan 27, 2020
I'll try to rebase and see if it's useful, didn't hear from you ;)
Author
edlebert
commented
Jan 27, 2020
Thank you! Yes, it definitely is an issue. It can happen for "waiting" Capybara code such as expect(page).to have_text 'Some Text' when the DOM can change during evaluation.
Contributor
okay, we have only one fail test after the merge with the updated master. Not bad! I will take a look, it is also nice to have some tests with the scenario
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's possible for Cuprite to evaluate the parents or the path for a node
that no longer belongs to the document.