-
-
Notifications
You must be signed in to change notification settings - Fork 97
Conversation
Antsiscool
commented
Sep 26, 2023
I am not sure why the tests are failing. They are all failing for me locally on the main branch as well.
brodienguyen
commented
Jan 4, 2024
I am interested in following up this contribution as well.
@route Not sure if you are the project's maintainer, but could you give us some insights if you know why all the tests are falling please?
44bc276 to
85b71ef
Compare
Antsiscool
commented
Jan 4, 2024
I have just rebased my changes onto the latest main branch.
route
commented
Jan 5, 2024
Just approved them to run
route
commented
Jan 7, 2024
Weird, dunno let me release new Ferrum and push my changes to cuprite and I'll get this into new release
lib/capybara/cuprite/node.rb
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest changing lib/capybara/cuprite/javascripts/index.js to:
} else if (node.type == "time") { this.setValue(node, value); this.input(node);
This way, input event will be emitted correctly and value attribute won't be modified unnecessarily.
janwerkhoven
commented
Aug 26, 2024
Need this. +1 👀
Do not modify time input value in JS Extract time inputs to seperate test file The test inputs load a data attribute for an SVG icon. This is changing the count of network requests in unrelated tests. Add support for week and month inputs
d3336eb to
d6f20e3
Compare
Antsiscool
commented
Feb 23, 2025
@route I have revisited this PR and cleaned it up. The issue with the original failing tests was that loading SVG icons for time and date inputs and this was increasing the count of network requests.
I have moved the time and date tests to a new HTML file and this has resolved the problem.
I have also added support for month and week inputs.
It seems the test suite is failing on Ruby 3.0 and Ruby 3.2. I have been unable to replicate these failures locally.
Antsiscool
commented
Feb 26, 2025
These failing tests seem to be flaky. I can replicate the issue locally.
I created a PR onto my fork to run the tests and they all passed. Antsiscool#1
I am converting a project over from capybara selenium and found that time inputs were failing to be correctly set.
This allows specifying the time as a string or a Time object. The date attributes will be ignored.
I have added test cases for both string and time. I also added some test cases for date inputs as well.