-
Notifications
You must be signed in to change notification settings - Fork 7
Comments
Make more options overridable in pgtest.PGConfig#7
Open
TheSalarKhan wants to merge 6 commits intorubenv:master from
Open
Make more options overridable in pgtest.PGConfig #7TheSalarKhan wants to merge 6 commits intorubenv:master from
pgtest.PGConfig #7TheSalarKhan wants to merge 6 commits intorubenv:master from
Conversation
CodeAshing
CodeAshing
approved these changes
Nov 14, 2024
@CodeAshing
CodeAshing
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Great work @TheSalarKhan
karelbilek
commented
Dec 18, 2024
I am not a maintainer here at all, but I personally find this a bit out of scope for this project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Hi @rubenv
Thanks allot for the amazing library, you might find this cool - maybe slightly concerning 🤣 - but we're using
pgtestto spin up temporary databases on the network, to provide quick databases for testing purposes.tl;dr we simply pipe TCP connections to unix sockets for
pgtestinstances spun up in real-time.But we can't do this unless we have predefined passwords/dbnames set (security, its on the network!). And in some instances - for longer running/multi-phase usecases - we need to disable Fsync.
So I've added options to the
pgtest.PGConfigconfig builder, which are used by the corestartmethod to tailor for specific cases.I have added tests that make sure this works.
Raising this PR in hopes that it unlocks more use-cases for this work of art.
Thanks a ton!