-
Notifications
You must be signed in to change notification settings - Fork 108
Conversation
jacobperron
commented
Jun 2, 2020
The workflow is refusing to run: https://github.com/ros2-java/ros2_java/actions/runs/123058318
After some searching, it sounds like we need to edit the settings for this repository (or the ros2-java org) to allow third-party GitHub actions. @esteve I don't have admin privileges, are you able to look into it?
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
998300f to
7701ed5
Compare
The Windows workflow is now running https://github.com/ros2-java/ros2_java/pull/109/checks?check_run_id=744698928
I had to push to your branch to trigger the CI, but there are no changes (I just force-pushed to change the tip of your branch). You may need to pull --rebase your local branch, though.
jacobperron
commented
Jun 8, 2020
@esteve Thanks 🙇
For Linux, it looks like a new flake8 error upstream. I think ament/ament_lint#252 should resolve the issue ultimately.
I'll continue looking into what's up with the Windows build.
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
This gives more control over which linters are run. For example, we don't need to depend on Python linters for many packages. This commit also worksaround an upstream issue with CI, where ament_cmake_flake8 is currently failing with a Dashing installation if flake8 is installed from pip. See ament/ament_lint#252 for a fix upstream. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
1eb9e45 to
e6495c7
Compare
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
jacobperron
commented
Jun 9, 2020
I've gotten one step further with Windows CI. Looks like I've run into a known issue with the ros-tooling/setup-ros action (ros-tooling/action-ros-ci#79).
* Fix Windows problem not finding ASIO. It basically needs an upgrade to setup-ros and action-ros-ci. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> * Fixes from review. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
This is an attempt at adding Windows CI via a GitHub workflow.