-
Notifications
You must be signed in to change notification settings - Fork 130
Adding script tags for abort fetch snippet #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@longqua69
longqua69
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your intention is good. It makes the snippet easier to understand. Removing the redundant space makes it better
README.md
Outdated
@longqua69
longqua69
Aug 18, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you should remove the redundant space for aligning.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah. sure.
@longqua69
longqua69
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool. Now it's time to merge
Uh oh!
There was an error while loading. Please reload this page.
Why?
Since this is vanilla JS you can put it under
<script></script>tags, so that it's easier to understand what's going on. Moreover the syntax highlight for the html snippet breaks due to the syntax highlight being configured to javascript. Keeping the syntax highlight to html keeps the highlight for html and javascript intact.