Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix path issues in v1.9.1 #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SanderSander wants to merge 1 commit into rmariuzzo:master
base: master
Choose a base branch
Loading
from SanderSander:master

Conversation

Copy link

@SanderSander SanderSander commented Aug 26, 2022

Fixes for the paths in v1.9.1

Copy link
Owner

@rmariuzzo rmariuzzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will wait to double check before merging.

Copy link

@Chomiciak Chomiciak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect ⭐

Copy link
Author

I updated the PR because of the prev commit was reverted (This PR includes those changes).

BTW, I think the original commit adds a feature, so instead releasing it as 1.9.1 a patch version, maybe consider to release it as a minor version 1.10.0

Copy link

Any news guys? I'm on Laravel 9 and I had to change the file directly to support the /lang folder instead of /resources/lang

SanderSander reacted with thumbs up emoji

Copy link
Owner

I apologize for the slow response. Will chech that today.

Copy link

Hi @rmariuzzo, any idea when this fix will be released? This issue is still causing many headaches for people using Laravel 9, and Laravel 10 is around the corner...

Copy link

@jonaszkadziela I recall we fixed the issue the day it was discovered by reverting breaking changes; update your dependency to the newest version (1.9.0) and you should be good to go.

rmariuzzo reacted with heart emoji

Copy link

@jonaszkadziela I recall we fixed the issue the day it was discovered by reverting breaking changes; update your dependency to the newest version (1.9.0) and you should be good to go.

Looking at the LaravelJsLocalizationServiceProvider class, it still does not locate files in the new default path which is project_root/lang:
https://github.com/rmariuzzo/Laravel-JS-Localization/blob/v1.9.0/src/Mariuzzo/LaravelJsLocalization/LaravelJsLocalizationServiceProvider.php#L75

Therefore, any fresh Laravel 9.x application or existing project that uses the new path does not work with this package. Running php artisan lang:js -c command leads to the following exception:
LaravelJsLocalization v1-9-0 - LangJsGenerator Exception

So, unfortunately, version 1.9.0 is not working. If this PR is merged, the issue should be resolved.

Copy link
Owner

I'm gonna take a look at this today, in a couple of hours.

cyrildewit and thiagorsantoskpmg reacted with thumbs up emoji

Copy link

thiagorsantoskpmg commented Feb 10, 2023
edited
Loading

Guys, is this fix released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmariuzzo rmariuzzo rmariuzzo approved these changes

+1 more reviewer

@Chomiciak Chomiciak Chomiciak approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /