Sensitivity - #63

Draft

jnnr wants to merge 45 commits into

dev from

features/sensitivity

Draft

Sensitivity #63
jnnr wants to merge 45 commits into
dev from
features/sensitivity

Conversation

@jnnr

@jnnr jnnr commented May 29, 2022 •

edited

Loading

Copy link

Copy Markdown

Collaborator

Allows to create new EnergyDatapackages from two existing EnergyDatapackages and a sampling function. First implemented sampling functions

Linear slide: LInear interpolation between the two datapackages.
SAlib sampling methods, e.g. latin hypercube sampling Sensitivity salib #64

jnnr added 30 commits

November 8, 2021 18:18

@jnnr


 Add sketch for sensitivity class

dd0f2f6

@jnnr


 Elaborate sanity checks

5057edf

@jnnr


 Pass assertion tests

13c5e8c

@jnnr


 Elaborate sanity checks

c254777

@jnnr


 Clean up sanity checks

39022da

@jnnr


 Sketch sampling

f533117

@jnnr


 Add test files for sensitivity

f9bb1e2

@jnnr


 Adapt sanity checks

0bcdf9d

@jnnr


 Decorate Sensitivity to allow passing EnergyDatapackage

9baa596

@jnnr


 Subclass instead of decorate

f49980e

@jnnr


 Use EDPsensitivity in the previous tests

ca5aa3a

@jnnr


 Add docstrings

4dd0905

@jnnr


 Drop attribute n as it belongs to the sammpling methods

@jnnr


 Define aux columns and var value centrally

cd7c722

@jnnr


 Rename variables assigned to EnergyDataPackage

70894ac

@jnnr


 Run sanity check at init

ee13007

@jnnr


 Fix index comparison

cd77212

@jnnr


 Add some tests

7b3cdbc

@jnnr


 Fix test_init by setting smaller epsilon and fixing comparison

343f1dc

@jnnr


 Save test EnergyDataPackages as unstacked

048376b

@jnnr


 Adapt tests of unstacked and stacked

a0d3673

@jnnr


  Assert failure upon init

24100d0

@jnnr


 Rearrange

b7957d8

@jnnr


 Check if EnergyDataPackage is stacked upon init

522b5f7

@jnnr


 Introduce attribute 'stacked'

01f297f

@jnnr


 Improve code formatting

df1030d

@jnnr


 Sketch sampling oat

0fc760b

@jnnr


 Remove incorrect elements

df74a21

@jnnr


 Copy datapackage before manipulation

01d924d

@jnnr


 Add sampling scheme linear slide

6948b9b

jnnr added 13 commits

April 4, 2022 12:32

@jnnr


 Fix test

f90b0bd

@jnnr


 Drop unfinished bits

dc5256d

@jnnr


 Wrap sampling method

49541c7

@jnnr


 Merge branch 'dev' into features/sensitivity

f8286a5

@jnnr


 Add Package metadata as attribute to EnergyDatapackage

d8f9d9e

@jnnr


 Sketch sampling with salib

ab13cc9

@jnnr


 Implement SAlib sampling

6dd1050

@jnnr


 Wrap sampling method

1cb6af3

@jnnr


 Clean up name

d9b6def

@jnnr


 Clean up test

f4d9da9

@jnnr


 Add requirement

b27567b

@jnnr


 Merge pull request #64 from rl-institut/feature/sensitivity-salib

03cd8e1

Sensitivity salib

@jnnr


 Give non-int name to samples

9f4d481

@jnnr jnnr mentioned this pull request

May 30, 2022

Sensitivity rl-institut/oemof-B3#220

Draft

jnnr added 2 commits

May 30, 2022 11:27

@jnnr


 Fix test after rename of samples

932e142

@jnnr


 Merge branch 'dev' into features/sensitivity

9e24131

jnnr

jnnr commented

Oct 13, 2022

View reviewed changes

@jnnr jnnr left a comment

Copy link

Copy Markdown

Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments:

oemoflex/model/variations.py

self.eps,

).all(), f"The difference between lb and ub is lower than the defined minimum of {self.eps}"

def get_diff(self):

@jnnr jnnr Oct 13, 2022

Copy link

Copy Markdown

Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revise naming

oemoflex/model/variations.py

def get_diff(self):

return get_diff(self.lb.loc[:, self.VAR_VALUE], self.ub.loc[:, self.VAR_VALUE])

def get_param(self):

@jnnr jnnr Oct 13, 2022

Copy link

Copy Markdown

Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revise naming

oemoflex/model/variations.py

self.sanity_check()

return _dp

def sanity_check(self):

@jnnr jnnr Oct 13, 2022

Copy link

Copy Markdown

Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Decouple sample method and sanity check.

oemoflex/model/variations.py

return full_samples

class EDPSensitivity(Sensitivity):

@jnnr jnnr Oct 13, 2022

Copy link

Copy Markdown

Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be done more general. The above Sensitivity class does checking and sampling for a single dataframe. This class is supposed to do the same for DataFramePackages.

The implementation takes some time to grasp - could be more transparent?

tests/test_sensitivity.py

# assert that the last sample equals the upper-bound datapackage

assert frame_containing_nan_equal(

samples["sample_" + str(n - 1)], edp_ub_stacked.data["component"]

)

@jnnr jnnr Oct 13, 2022

Copy link

Copy Markdown

Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a check that actually compares results files.

Navigation Menu

Uh oh!

Sensitivity - #63

Sensitivity #63
jnnr wants to merge 45 commits into
dev from
features/sensitivity

Conversation

@jnnr jnnr commented May 29, 2022 •

edited

Loading

Uh oh!

Uh oh!

@jnnr jnnr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

@jnnr jnnr Oct 13, 2022

Choose a reason for hiding this comment

Uh oh!

@jnnr jnnr Oct 13, 2022

Choose a reason for hiding this comment

Uh oh!

@jnnr jnnr Oct 13, 2022

Choose a reason for hiding this comment

Uh oh!

@jnnr jnnr Oct 13, 2022

Choose a reason for hiding this comment

Uh oh!

@jnnr jnnr Oct 13, 2022

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

@jnnr jnnr commented May 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

@jnnr jnnr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

@jnnr jnnr Oct 13, 2022

Choose a reason for hiding this comment

Uh oh!

@jnnr jnnr Oct 13, 2022

Choose a reason for hiding this comment

Uh oh!

@jnnr jnnr Oct 13, 2022

Choose a reason for hiding this comment

Uh oh!

@jnnr jnnr Oct 13, 2022

Choose a reason for hiding this comment

Uh oh!

@jnnr jnnr Oct 13, 2022

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

@jnnr jnnr commented May 29, 2022 •

edited

Loading