-
Notifications
You must be signed in to change notification settings - Fork 1
Draft
Conversation
Collaborator
Author
Added constraint tests for storage and asymmetric storage and checked the lp-files:
- storage_investment_greenfield: Ok
- asymmetric_storage_investment_greenfield: Ok
- storage_investment_brown_field:
- Bug in constraint c_e_GenericInvestmentStorageBlock_power_coupled(storage)_
Input and output capacity should be the same.
Fix: Pass self.existing to the invest object of the output flow. - Not a bug, but may be better to adapt it: Currently, potentials relate to the invested capacity on top of existing, not on the sum of existing and additionally invested. E.g., if there is an existing capacity of 3 (MW) and a potential of 5 (MW), the max would be 8 MW. Usually though, potential means the total potential, including the part of it that is already realized. Should pass max = potential - existing to the investment objects.
- Both are addressed in Fix: Storage Investment oemof/oemof-tabular#33
- Bug in constraint c_e_GenericInvestmentStorageBlock_power_coupled(storage)_
- asymmetric_storage_investment_brown_field:
- Again, potentials relate to invested capacity, irrespective of how much capacity already exists. This does not reflect the common usage of "potential". Defined in the bounds of the investment variables.
- Done in dc67789
4 tasks
Collaborator
Author
TODO: Keep the tests and fixes for assymetric storage in a separate branch, but drop the test for storage to avoid duplication with oemof.tabular.
I keep this open and postpone this to the next release. In the meantime, AssymetricStorage could move to oemof.tabular's experimental facades anyway oemof/oemof-tabular#46.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
This PR adds tests of storage investment with the constraint of
capacity_potential,storage_capacity_potential,capacity_potential_charge/dischargeforStorageandAssymetricStorage.