Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix(nodejs): scope npm/npx host fallback roots#72

Open
atharvasingh7007 wants to merge 1 commit into
rivet-dev:main from
atharvasingh7007:fix/npm-host-fallback-scope
Open

fix(nodejs): scope npm/npx host fallback roots #72
atharvasingh7007 wants to merge 1 commit into
rivet-dev:main from
atharvasingh7007:fix/npm-host-fallback-scope

Conversation

@atharvasingh7007

@atharvasingh7007 atharvasingh7007 commented Apr 12, 2026

Copy link
Copy Markdown

Summary

  • scope npm/npx host fallback reads to the resolved npm package roots
  • only retry host reads after ENOENT from the kernel VFS
  • keep write-like operations on the kernel VFS and add regression coverage for the fallback wrapper

Why

The host fallback wrapper in packages/nodejs/src/kernel-runtime.ts currently retries host filesystem reads after any kernel-VFS read failure. During npm/npx execution that can broaden fallback beyond npm's own installation tree instead of limiting it to npm-owned files.

This change derives explicit allowed host roots from the resolved npm/npx entry package, preserves non-ENOENT failures from the base VFS, and removes host fallback for pwrite so the wrapper stays read-only.

Validation

  • pnpm --filter @secure-exec/core build
  • pnpm --filter @secure-exec/v8 build
  • pnpm --filter @secure-exec/nodejs check-types
  • pnpm --filter @secure-exec/nodejs build
  • pnpm --filter @secure-exec/nodejs exec vitest run test/kernel-runtime.test.ts -t "host fallback scoping"

Note

  • pnpm --filter @secure-exec/nodejs test still fails in this Windows checkout because the broader integration suite expects secure-exec-v8 to be available on PATH for runtime-backed tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

AltStyle によって変換されたページ (->オリジナル) /