-
Notifications
You must be signed in to change notification settings - Fork 278
Open
Conversation
@thboileau
thboileau
force-pushed
the
2.4
branch
4 times, most recently
from
October 26, 2017 20:23
660ec16 to
423c818
Compare
Tembrel
commented
Jan 30, 2018
Collaborator
Does this really carry its weight? If so, how about:
public long getAge(TimeUnit unit) {
Date date = getDate();
if (date == null) {
return Long.MIN_VALUE; // Long.MAX_VALUE?
} else {
long ageMillis = System.currentTimeMillis() - date.getTime();
return unit.convert(ageMillis, TimeUnit.MILLISECONDS);
}
}
You want to be able to distinguish the case of the age being 0 from the case where there is no date.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add method get age in ms for Message class